Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New routes created for UDP and TCP #20

Merged
merged 1 commit into from
Jan 5, 2020
Merged

New routes created for UDP and TCP #20

merged 1 commit into from
Jan 5, 2020

Conversation

Pipe-Runner
Copy link
Collaborator

@Pipe-Runner Pipe-Runner commented Jan 4, 2020

Reference issue
#17

PR description:
Create adaptors for tcp based communications with the hub

List of changes made in this PR:

  • Added http header file
  • Added http source file
  • Fixed a cmake bug
  • Added new udp_interface headers and source files

Does this break the platform?
N

@Pipe-Runner Pipe-Runner changed the title New routes created for TCP New routes created for UDP Jan 5, 2020
@Pipe-Runner Pipe-Runner changed the title New routes created for UDP New routes created for UDP and TCP Jan 5, 2020
boost::array<char, 1> recv_buffer_;

void start_receive();
void handle_receive(const boost::system::error_code &, std::size_t);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comments about method above it and add meaningful parameter names.

if (!error || error == boost::asio::error::message_size) {
boost::shared_ptr<std::string> message(new std::string("Test string"));

socket_.async_send_to(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comments.

@dhirajfx3 dhirajfx3 merged commit 82734d4 into master Jan 5, 2020
@dhirajfx3 dhirajfx3 deleted the routes branch January 5, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants