Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing required npm version so the package will work with future… #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BruceHubbard
Copy link

Changing required npm version so the package will work with future npm versions

@BruceHubbard
Copy link
Author

@mavarazy I know this package looks like it's not being maintained any longer but is it possible to get this PR merged and a new version pushed out? This just changes the npm version in the package.json because this package will no longer install in higher versions of npm if you have engine-strict=true set due to the "npm": "^2.14.7", setting. It's the only package out of the hundreds we use that has this problem and we would prefer not to fork and host our own version.

Copy link
Contributor

@Steffan-Ennis Steffan-Ennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sensible

@BruceHubbard
Copy link
Author

@mavarazy @Steffan-Ennis What's the process to get this merged and released? I don't see any labels or actions set up for the repo. Were you guys manually publishing this package? Should I bump the version in the package.json in this PR?

@ayrusme
Copy link

ayrusme commented Nov 9, 2022

@mavarazy @Steffan-Ennis is it possible to get this merged? thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants