Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix select more|less processing #296

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

d-m-bailey
Copy link

Fixes #295

However, I feel that this is a bad patch to a poor implementation.

@d-m-bailey
Copy link
Author

There may be a better solution. Don't merge this just yet.

@d-m-bailey
Copy link
Author

@RTimothyEdwards Instead of modifying tx_argc, I was considering using a pstart variable like in commands/CmdFI.c to keep track of the first relevant parameter. However, tx_argc is used in many places.
In other commands/Cmd*.c programs, locargc is used.

The solution in this merge is a kludge, but it may be a minimal change.

Could you please decide what to do?

@RTimothyEdwards
Copy link
Owner

I just pushed what I think is the right solution to this issue. The CmdSelect() code was messing with the number of arguments directly instead of keeping a separate count of non-qualifier arguments. My correction appears to solve the issue with "select more cell" and "select less cell" without breaking anything else, and the code is cleaner.

@d-m-bailey
Copy link
Author

@RTimothyEdwards as always, thanks for looking into this. I'll test it once it's on the public repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

select more cell <instance> does not work.
2 participants