Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tool][cmake] Let cmake generator get more param from rtconfig.py #9139

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

kaidegit
Copy link
Contributor

@kaidegit kaidegit commented Jul 4, 2024

  • support getting c/cpp standard from c/cpp compilation flags
  • support getting post action and conv it to cmake variable
  • add a custom cmake file for user custom settings
  • support setting project name from --project-name= option

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

生成的cmake有一些硬编码的东西,且部分参数并没有去rtconfig.py中读取,对于依赖cmake的ide,如clion,在修改时不是很友好。

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP: art-pi

  • .config:

  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification (似乎并没有规定python代码的风格)

* support getting c/cpp standard from c/cpp compilation flags
* support getting post action and conv it to cmake variable
* add a custom cmake file for user custom settings
* support setting project name from `--project-name=` option
@CLAassistant
Copy link

CLAassistant commented Jul 4, 2024

CLA assistant check
All committers have signed the CLA.

@kaidegit kaidegit changed the title let cmake generator get more param from rtconfig.py [tool][cmake] Let cmake generator get more param from rtconfig.py Jul 4, 2024
@Rbb666 Rbb666 added the tools label Jul 5, 2024
@mysterywolf
Copy link
Member

请详细解释一下修改的内容和使用方法,方便后续归档谢谢

@kaidegit
Copy link
Contributor Author

kaidegit commented Jul 6, 2024

修改的内容:

  • 添加了从rtconfig.py中读取post action并处理:替换工具和$TARGET为cmake变量
  • 添加了从C/C++的编译参数中匹配C/C++的版本
  • 添加了自动包含custom.cmake
  • 添加了从cli参数读取工程名

使用方法应该没什么变化,并添加了--project-name参数支持,scons --target=cmake scons --target=cmake --project-name=xxxx即可

@mysterywolf mysterywolf merged commit d266ed6 into RT-Thread:master Jul 6, 2024
44 checks passed
@mysterywolf
Copy link
Member

感谢提交PR 如果使用cmake过程中发现有问题也欢迎继续提交PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants