-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change overlayroot to use /etc/overlayroot.local.conf instead of cmdine.txt, and make it compatible with users' configuration #225
base: bookworm
Are you sure you want to change the base?
Conversation
…ine.txt, and make it compatible with users' configuration
A little more detail on how this makes raspi-config more compatible with users' overlayroot configuration: It is quite common for those utilizing the readonly overlay to also have another read/write partition or disk. Beginning with Bookworm, the overlayroot, through its default For users that need a read/write partition or disk, they can add a commented line of |
It is also possible to disable the overlay by adding |
@XECDesign @ghollingworth Have you any thoughts on this? |
It has a few nice features over what we have already. However, what we have already had been tested and works, so this isn't on my todo list right now. |
I think it would be great if this or something like this would be supported. My current workaround is not pretty (applying this patch to |
The reason for this pull request is that the current implementation does not work for those that utilize additional read-write partitions/disks. Edit: Also, the implementation in Bullseye did work with read-write partitions and disks, so the implementation in Bookworm potentially breaks existing solutions. |
Just to add... I have a HAT that has a spi-nand memory device for use as r/w storage. Enabling the overlay on the pi (Bookworm) unexpectedly added the mount for that device to the overlay. This never happened in Bulleseye and previous. |
See raspberrypi/bookworm-feedback#137 for a discussion of what prompted this pull request.
I believe the procedures to enable and disable the readonly file system overlay can be improved.
My understanding is that Raspberry Pi would prefer to follow the conventions and best practices of upstream repositories whenever possible. As I did my research on the aforementioned issue, I discovered, in the overlayroot documentation, that it should be enabled by modifying the /etc/overlayroot.local.conf file (See /etc/overlayroot.conf for documentation), and that changes to any overlayed file system can be made through the
overlayroot-chroot
command. See https://manpages.debian.org/bookworm/overlayroot/overlayroot-chroot.8.en.htmlThis method a few advantages:
Although it is no longer necessary to reboot twice when enabling/disabling write protection on the /boot partition, I have not made such a change to keep this pull request as least intrusive as possible. Should this pull request be pulled, a subsequent pull request could be made to enable/disable overlayroot and the write protection on the boot partition simultaneously when one reboot.