matmul performance regression pipeline #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexAUT
changed the title
AlexAUT
force-pushed
the
perf_regression_pipeline
branch
from
eaa7acd
to
8b532b4
Compare
|
@AlexAUT Is this PR for testing purpose only? IIRC, github does not have MI300 runners, does it? |
|
Was a confusion due to the call on Tuesday. I reverted it back to the jenkins pipeline. I will ping here when this is tested. The mi300 runners are quite congested at the moment. |
AlexAUT
force-pushed
the
perf_regression_pipeline
branch
6 times, most recently
from
429661f
to
f2510ae
Compare
|
Most changes we discussed last week are implemented. Should we merge this as a first step. We can add tests for other kernels/datatypes as a separate pull request? |
zhanglx13
approved these changes
Oct 15, 2024
…es no specify otherwise
zhanglx13
force-pushed
the
perf_regression_pipeline
branch
from
f2510ae
to
76ca04b
Compare
micmelesse
pushed a commit
that referenced
this pull request
Oct 28, 2024
* Added regression tests to tune_gemm * Add regression tests to pipelines * Add missing imports * Use warnings to signal that no performance comparison is found * Split regression tests into separate file * Disable github pipeline in favour of jenkins * Improve output and skip tests if no performance reference can be found * Add testcase for overall mean regression * Extend parameters which can be adjusted for perf regression tests * Switch to geo mean for overall result * Always recompile kernels in perf regression tests in case the user does no specify otherwise * Report default values in exported result to support changing them in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a pipeline step to test for a performance regression for matmul.
It compares the performance with the last successful workflow from the main_perf branch. The workflow is started for each pull request into main_perf and for the main_perf branch after the merge. This run will then act as the new baseline if it was successful.