RMSNorm Blocked Implementation #638
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulbatra85
force-pushed
the
rmsnorm_updates
branch
2 times, most recently
from
207f73a
to
44e9360
Compare
brunomazzottiamd
approved these changes
Oct 1, 2024
rahulbatra85
force-pushed
the
rmsnorm_updates
branch
from
44e9360
to
918bcbc
Compare
rahulbatra85
force-pushed
the
rmsnorm_updates
branch
from
918bcbc
to
381b660
Compare
brunomazzottiamd
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to using blocks for columns. This gives much better performance specially for larger n_cols sizes