-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed streamk kernel bug #602
base: streamk-no-atomic
Are you sure you want to change the base?
Conversation
Hi, @xiaohuguo2023, Can you check whether the numerical results are correct? |
Thanks @ravil-mobile , this does fix the compiling issue, but not the numerical results which are caused by the spinning locks. |
And the interesting part is that we don't really need another allocation at line 80, however, if I delete line 80, we will end up with the same error below:
|
@@ -76,6 +77,7 @@ def persistent_streamk_gemm( | |||
mask = (rm < M)[:, None] & (rn < N)[None, :] | |||
tl.store(C_, acc, mask=mask) | |||
|
|||
acc = tl.zeros((BLOCK_SIZE_M, BLOCK_SIZE_N), dtype=acc_dtype) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we could remove this line, we will get better perf
No description provided.