-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop stream 2024-06-26 #575
Develop stream 2024-06-26 #575
Conversation
37b6770
to
b43c034
Compare
Rebased and added a fix that resolves #570 |
Fixed doxygen errors in 8d5b5e8 |
8d5b5e8
to
4651b07
Compare
4651b07 Noticed CI failures after targeting a later commit in develop. 6edfe13 Should fix one of the test failures on MI200 with very large inputs. Also rebased it, again. |
Thanks Nara, I will rerun CI right now. |
I managed to test this on a MI200. It turns out, for reasons I'm not fully aware of, that running |
Re-running CI now. It does seem strange that an explicit hipStreamSynchronize is required here since this function only deals with one stream and all kernels are being executed on that stream and I don't see any data race conditions here. Maybe we can make a small reproducer and file a bug report with the HIP team? |
It seems as though the hang still persists on MI200 on CI, even with the hipStreamSychronize(). |
ea06706
to
930bdab
Compare
Rebased & resolved conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the packaging version at https://github.com/ROCm/rocPRIM/pull/575/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aL133 to 3.3.0 as well? Thanks.
Done in 8d06855. |
Thanks. |
8d06855
to
5f20e73
Compare
…or device transform
…ontinuity These tests take extremely long time to build with clang from ROCm 6.1+.
…enerate_random_data_n
…::get_random_data
…pulate step when fetching it by source
5f20e73
to
87abd8c
Compare
@Naraenda is taking this over since @Snektron is on holiday.
This PR adds the following merge commits. Emphasis on important changes.
partial_sort
andpartial_sort_copy
algorithmsrocprim::inclusive_scan
,rocprim::exclusive_scan
,rocprim::inclusive_scan_by_key
,rocprim::exclusive_scan_by_key
, androcprim::reduce_by_key
rocprim::detail::merge_path