Patches relating to OpenMP imperfect loop collapse #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estewart08
reviewed
Jun 20, 2024
estewart08
reviewed
Jun 20, 2024
bin/rocm-test/scripts/parse_LLNL.sh
Outdated
| @@ -49,6 +52,10 @@ function parse(){ | |||
| fi | |||
| [[ "$line" =~ $testname_regex ]] | |||
| llnltest=${BASH_REMATCH[1]} | |||
| if [ "$outfile" = "failing-tests.txt" ] && \ | |||
| grep -Fq "$llnltest" xfail-list then | |||
There was a problem hiding this comment.
Missing a semi-colon here after xfail-list.
There was a problem hiding this comment.
...huh, but yeah. I wonder why it didn't complain! I'll fix that, thanks.
|
Just to confirm, we expect |
Yes (although the "test_imperfect_loop" of course xfails, in this hackish new way). |
This patch uses the subprocess 'communicate' method in the LLNL Python test script, as recommended in the documentation, and adds some return-code checks. This was mostly done as a side-effect of investigating another problem, but is probably helpful anyway.
This patch provides a somewhat ad-hoc way of adding compilation options to particular tests in the LLNL/openmp5.0-tests suite. In the test_list file, just write options after a forward slash: foo.cpp / --extra-opt
This patch fixes a mysterious bug with the LLNL test script: if it takes more than two minutes to run, it silently exits without producing any output (with logging enabled). This can happen for debug builds of the compiler, even on a fast machine. This happens because the underlying Python script buffers output because it knows it is writing to a pipe. But if the 'timeout' command kills that script before it has completed, all its output is then discarded. The fix is twofold: firstly the "timed-out" condition is now detected in the check_LLNL.sh script, and secondly the timeout time is increased.
This patch adds the -Ropenmp-opt=analysis option to the compilation of the test_imperfect_loop.cxx LLNL/openmp5.0-tests test, and a new pseudo-test to check that the right 'remark' is emitted by the compiler. This depends on the upstream PR: llvm/llvm-project#96087
The test test_imperfect_loop.cxx contains a loop collapse operation that cannot be executed safely in parallel, so should be marked as expected to fail, somehow. This patch adds a basic way to do that.
This patch adds some error checking to the parse_LLNL.sh script, and avoids parsing `ls` output when looking for the results file.
This patch splits the smoke-fails/imperfect-loop-collapse test into two variants, one of which does and one which doesn't need unified shared memory (which is orthogonal to the main purpose of the test). It also fixes the HSA_XNACK setting for smoke-fails/imperfect-loop-collapse-usm version, so both versions now work.
estewart08
approved these changes
Jun 27, 2024
|
Thank you for the approval! I can't merge this though -- it could wait until the upstream imperfect loop analysis option lands on amd-staging, but it probably doesn't need to (just the "remark" output-scanning test will fail for now, I guess). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various patches relating to internal issue SWDEV-229378 (upstream PR llvm/llvm-project#96087)