-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for multiple dyn libs containing OpenMP target regions #458
base: aomp-dev
Are you sure you want to change the base?
Conversation
|
||
# override default run rule | ||
run: | ||
HSA_XNACK=1 LD_LIBRARY_PATH=${PWD} ./dyn_libs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You would want to put this into a RUNCMD
variable, which is picked up by the Makefile machinery automatically.
Otherwise the special rule will not be picked up the make check
, which executes in check_smoke.sh
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the HSA_XNACK
and LD_LIBRARY_PATH
setting should go into RUNENV
and the Makefile should require a GFX that is capable of USM/XNACK.
You can do this now by setting
SUPPORTED = $(SUPPORTS_USM)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated this review with some more info on how to limit the test to USM-capable devices.
|
||
# override default run rule | ||
run: | ||
HSA_XNACK=1 LD_LIBRARY_PATH=${PWD} ./dyn_libs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the HSA_XNACK
and LD_LIBRARY_PATH
setting should go into RUNENV
and the Makefile should require a GFX that is capable of USM/XNACK.
You can do this now by setting
SUPPORTED = $(SUPPORTS_USM)
CFLAGS = $(AOMP_CPUTARGET) -fopenmp -fopenmp-targets=$(AOMP_GPUTARGET) \ | ||
-Xopenmp-target=$(AOMP_GPUTARGET) \ | ||
-march=$(AOMP_GPU) -O2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this use --offload-arch=$(AOMP_GPU)
instead of the more verbose syntax?
No description provided.