Add test for multiple dyn libs containing OpenMP target regions #458
Conversation
|
|
||
| # override default run rule | ||
| run: | ||
| HSA_XNACK=1 LD_LIBRARY_PATH=${PWD} ./dyn_libs |
There was a problem hiding this comment.
You would want to put this into a RUNCMD variable, which is picked up by the Makefile machinery automatically.
Otherwise the special rule will not be picked up the make check, which executes in check_smoke.sh.
There was a problem hiding this comment.
Also, the HSA_XNACK and LD_LIBRARY_PATH setting should go into RUNENV and the Makefile should require a GFX that is capable of USM/XNACK.
You can do this now by setting
SUPPORTED = $(SUPPORTS_USM)
|
|
||
| # override default run rule | ||
| run: | ||
| HSA_XNACK=1 LD_LIBRARY_PATH=${PWD} ./dyn_libs |
There was a problem hiding this comment.
Also, the HSA_XNACK and LD_LIBRARY_PATH setting should go into RUNENV and the Makefile should require a GFX that is capable of USM/XNACK.
You can do this now by setting
SUPPORTED = $(SUPPORTS_USM)
| CFLAGS = $(AOMP_CPUTARGET) -fopenmp -fopenmp-targets=$(AOMP_GPUTARGET) \ | ||
| -Xopenmp-target=$(AOMP_GPUTARGET) \ | ||
| -march=$(AOMP_GPU) -O2 |
There was a problem hiding this comment.
Should this use --offload-arch=$(AOMP_GPU) instead of the more verbose syntax?
No description provided.