GTests Refactoring: Merge to Develop From Integration branch #3309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…movingEnvVarsFromGTests
…movingEnvVarsFromGTests
…movingEnvVarsFromGTests_C-F
…movingEnvVarsFromGTests
…movingEnvVarsFromGTests_G-P
…movingEnvVarsFromGTests_C-F
[GTests Refactoring] Removing MIOPEN_TEST_ALL and MIOPEN_TEST_FLOAT_ARG env variables. Part 1.
…movingEnvVarsFromGTests_G-P
…movingEnvVarsFromGTests_R-U
…_C-F [GTests Refactoring] Removing MIOPEN_TEST_ALL and MIOPEN_TEST_FLOAT_ARG env variables. Part 2.
…emovingEnvVarsFromGTests_Fin
…emovingEnvVarsFromGTests_Fin
…_G-P [GTests Refactoring] Removing MIOPEN_TEST_ALL and MIOPEN_TEST_FLOAT_ARG env variables. Part 3.
…_R-U [GTests Refactoring] Removing MIOPEN_TEST_ALL and MIOPEN_TEST_FLOAT_ARG env variables. Part 4.
…movingEnvVarsFromGTests_Fin
…_Fin [GTests Refactoring] Removing MIOPEN_TEST_ALL and MIOPEN_TEST_FLOAT_ARG env variables. Part 5 (Finalization)
…_Fin2 [GTests Refactoring] Removing MIOPEN_TEST_ALL and MIOPEN_TEST_FLOAT_ARG env variables. Part 6 (small)
Setting MIOPEN_TEST_ALL and MIOPEN_TEST_FLOAT_ARG env variables is removed in cmake
Vsevolod1983
requested review from
CAHEK7,
BrianHarrisonAMD and
junliume
and removed request for
JehandadKhan and
junliume
BrianHarrisonAMD
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
LGTM!
Awesome work, and good to see this cleaned up!
As part of verifying this, it would be good to compare the skipped list between develop and this branch to ensure they still line up for the different stages. They should be mostly identical. There are a couple areas where we intentionally changed the naming, or the Full / Smoke stages, because we noticed they were wrong, and those won't line up, but otherwise it should be identical.
junliume
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MIOPEN_TEST_ALL and MIOPEN_TEST_FLOAT_ARG env variables removed from GTests.
This is an integration branch, so all PRs were reviewed recently:
#3269
#3276
#3278
#3286
#3296
#3300
#3306