-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ck mha fp16 solver #3277
Merged
BrianHarrisonAMD
merged 17 commits into
bharriso/integrate-ck-mha-fp16
from
bharriso/add-ck-mha-fp16-solver
Oct 4, 2024
Merged
Add ck mha fp16 solver #3277
Changes from 8 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
04ab62e
Add CK FA v2 solver
BrianHarrisonAMD 5b4a58b
Apply formatting
BrianHarrisonAMD 367cf33
Add define guard around CK implementation
BrianHarrisonAMD b213750
Add support for masking option
BrianHarrisonAMD 9d29e2c
Fix hip-tidy issues
BrianHarrisonAMD 75caf69
Add registering new CK solver
BrianHarrisonAMD dcf8636
Apply formatting
BrianHarrisonAMD bd132b4
Code review comments
BrianHarrisonAMD bb3b268
Fix incorrect check for CK define
BrianHarrisonAMD e4dab66
Merge remote-tracking branch 'origin/develop' into bharriso/add-ck-mh…
BrianHarrisonAMD f6076c3
Add additional details to the register comment to prevent missed conf…
BrianHarrisonAMD 0545995
Update RunImpl to select proper solver
BrianHarrisonAMD 00e4df6
Apply formatting
BrianHarrisonAMD abcbef4
Add checking stride conditions since D must be contigious
BrianHarrisonAMD d3526b6
Fix IsApplicable check to properly check for device support.
BrianHarrisonAMD 82198ad
Apply formatting
BrianHarrisonAMD ff0004f
Add bias back after accidentally removing for testing
BrianHarrisonAMD File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,5 +7,5 @@ nlohmann/[email protected] -DJSON_MultipleHeaders=ON -DJSON_BuildTests=Off | |
ROCm/[email protected] | ||
ROCm/[email protected] | ||
ROCm/frugally-deep@9683d557eb672ee2304f80f6682c51242d748a50 | ||
ROCm/composable_kernel@9c0811f39a2262dbe4d71b81898187951c1e11ba -DCMAKE_BUILD_TYPE=Release -DINSTANCES_ONLY=ON | ||
ROCm/composable_kernel@294cb823142a815170cf1faa63e01a431a557a04 -DCMAKE_BUILD_TYPE=Release -DINSTANCES_ONLY=ON | ||
google/[email protected] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, this is pointing to a dev commit where I added generating the device_mha_operations lib for gfx90a as well.
This will need to be updated to point to an amd-develop commit instead once it's been promoted.
Since this is living in a integration branch it should be fine for now, but we shouldn't merge the integration into develop until this is resolved.