-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement MultiMarginLoss forward #3166
base: develop
Are you sure you want to change the base?
Conversation
Please check this comment #3146 (comment) @CAHEK7 . I have fixed all things like your recommendation. |
3aa5d70
to
1705be3
Compare
@CAHEK7 I have updated the code, which included your recommendation:
|
@CAHEK7 I also merged solvers to 1 file to avoid duplicated code, please check if it satisfied your recommendation. Thank you. |
[off-topic] @littlecutebird Can you please provide email address at your github profile page? Thanks. |
I have updated it, please check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocked by CI failure. Need to restart after CI issue was fixed.
[2024-09-23T13:54:42.218Z] Exception occurred: org.kohsuke.github.HttpException: {"message":"API rate limit exceeded for user ID 49319081. If you reach out to GitHub Support for help, please include the request ID
@littlecutebird there are some CI issues and need code clean up (resolve conflict etc). Thanks!
|
IsImprovementOverROCm
function insrc/solver/multimarginloss/forward_reduced_multimarginloss.cpp
to see the exact number.Unreduced:
fp32
fp16
bfp16
Reduced:
fp32
fp16
bfp16