Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default instance name at startup #308

Merged
merged 15 commits into from
Oct 28, 2024
Merged

Conversation

PhillipsOwen
Copy link
Collaborator

@PhillipsOwen PhillipsOwen commented Oct 24, 2024

this addresses an issue in #288 , #302

this is a implementation of getting/setting/resetting (via a UI data web-service) the default instance name to use when the app starts up. there are a number of things to test in this update as it spans:

  • numerous aspects of the UI initial data gathering of map and control-panel data.
  • the UI Data app that set/gets/resets the default startup instance name.

it also addresses bugs/tidying up in some other unrelated code discovered in testing. such as:

  • improving the tool-tip text on the alert popup.
  • not allowing geo-point selection whilst in compare mode.
  • bug in adcirc-raster-layer.js when no product type is set for the current opacity setting.
  • minor refactoring for code readability and comments.

@lstillwe
Copy link
Contributor

There is a 1 high severity vulnerability.

@PhillipsOwen
Copy link
Collaborator Author

im not seeing it. what are you seeing?

PS C:\Users\powen\PycharmProjects\APSVIZ\APSViz-UI-data> npm audit
found 0 vulnerabilities

@lstillwe
Copy link
Contributor

RENCI_PR6KF12JVC:APSViz-UI-V3 lisa$ git status
On branch issue-288-default-startup-layers
Your branch is up to date with 'origin/issue-288-default-startup-layers'.

nothing to commit, working tree clean
RENCI_PR6KF12JVC:APSViz-UI-V3 lisa$ npm audit

npm audit report

http-proxy-middleware <2.0.7
Severity: high
Denial of service in http-proxy-middleware - GHSA-c7qv-q95q-8v27
fix available via npm audit fix
node_modules/http-proxy-middleware

1 high severity vulnerability

To address all issues, run:
npm audit fix
RENCI_PR6KF12JVC:APSViz-UI-V3 lisa$

Copy link
Contributor

@lstillwe lstillwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@lstillwe lstillwe merged commit 6d240f0 into main Oct 28, 2024
@lstillwe lstillwe deleted the issue-288-default-startup-layers branch October 28, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants