Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to KordEx v2 #114

Merged
merged 11 commits into from
Oct 10, 2024
Merged

Update to KordEx v2 #114

merged 11 commits into from
Oct 10, 2024

Conversation

gdude2002
Copy link
Contributor

@gdude2002 gdude2002 commented Aug 16, 2024

This PR makes the following changes:

  • Update to KordEx v2
  • Remove @WiredPlugin usage and replace it with the plugin { } block in the Gradle plugin configuration
  • Remove the mappings extension, since @sschr15 is still AWOL and hasn't OK'd it for KordEx v2's licensing
  • Configure the new /about command
  • Set the data collection mode to "Minimal" (decided by @OroArmor)
  • Fix the formatting in the Minecraft patch notes extension b/c it was pissing me off (format blockquotes and italics, triple embed length)
    • This also includes an "update" command that requests that a message be edited with the patch notes of the given version
    • I also fixed the permissions for the /mc management subcommands, as previously they required both the mod role and the admin perm, when they should've accepted either

You should use the dev Gradle task to launch the bot in development going forward, instead of run

For more information on what changed in v2, make sure you read up!

As usual, I don't have an environment to test this in. It was a pretty painless update, but someone should still test it before merging.

BEFORE YOU MERGE CHECKLIST

  • Test the bot
    • Update your IDE config to use the dev Gradle task instead of run for testing

@kb-1000
Copy link

kb-1000 commented Aug 16, 2024

Removing the mappings feature does make cozy quite a bit less useful IMO

@gdude2002
Copy link
Contributor Author

gdude2002 commented Aug 16, 2024

That change was also made at the request of the infra team, who are currently working with limited machine resources.

@gdude2002
Copy link
Contributor Author

Please note that we've run into a problem with how KSP generates its tasks - it seems to be a timing issue created by KSP, and I'm still looking for a way to work around it in the KordEx plugin.

@gdude2002
Copy link
Contributor Author

This problem has been fixed.

@gdude2002
Copy link
Contributor Author

gdude2002 commented Aug 28, 2024

I fixed the patch notes. Merry Chrysler.

Copy link
Contributor

@Southpaw1496 Southpaw1496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the bot and it seems to be working as intended. A couple of notes:

  • You've already made the necessary IDE updates for IDEA users, right?
  • I've noticed that there's a lot of line breaks in between headings with the mc command. Is this new behaviour?
Screenshot 2024-10-04 at 6 00 44 pm

@gdude2002
Copy link
Contributor Author

You've already made the necessary IDE updates for IDEA users, right?

I'm an IDEA user and things seem to work fine?

I've noticed that there's a lot of line breaks in between headings

There are no additional line breaks iirc, it's just that it uses actual markdown headings now - feel free to remove one of them if you think it'd work better

@ix0rai ix0rai added the enhancement New feature or request label Oct 10, 2024
@ix0rai ix0rai merged commit 956d2e7 into QuiltMC:root Oct 10, 2024
1 check passed
@gdude2002 gdude2002 deleted the v2 branch October 10, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants