-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to KordEx v2 #114
Update to KordEx v2 #114
Conversation
Removing the mappings feature does make cozy quite a bit less useful IMO |
That change was also made at the request of the infra team, who are currently working with limited machine resources. |
Please note that we've run into a problem with how KSP generates its tasks - it seems to be a timing issue created by KSP, and I'm still looking for a way to work around it in the KordEx plugin. |
This problem has been fixed. |
I fixed the patch notes. Merry Chrysler. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm an IDEA user and things seem to work fine?
There are no additional line breaks iirc, it's just that it uses actual markdown headings now - feel free to remove one of them if you think it'd work better |
This PR makes the following changes:
@WiredPlugin
usage and replace it with theplugin { }
block in the Gradle plugin configuration/about
command/mc
management subcommands, as previously they required both the mod role and the admin perm, when they should've accepted eitherYou should use the
dev
Gradle task to launch the bot in development going forward, instead ofrun
For more information on what changed in v2, make sure you read up!
As usual, I don't have an environment to test this in. It was a pretty painless update, but someone should still test it before merging.
BEFORE YOU MERGE CHECKLIST
dev
Gradle task instead ofrun
for testing