Solves bug related to fitting using __curve_fit with x errors #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fitting to custom functions through the
__curve_fit
method, if the data includes x errors and the function is decreasing, the errors on the parameters will decrease as the x errors increase until the method returns the following error:RuntimeError: Optimal parameters not found: Number of calls to function has reached maxfev = 600.
The following code was used to test this as well as my fix;
It may be a good idea to use scipy.odr instead when there are x errors.