Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional_fields to all @jobs #2405

Merged
merged 2 commits into from
Aug 10, 2024
Merged

Add additional_fields to all @jobs #2405

merged 2 commits into from
Aug 10, 2024

Conversation

Andrew-S-Rosen
Copy link
Member

@Andrew-S-Rosen Andrew-S-Rosen commented Aug 10, 2024

Summary of Changes

This PR addresses the request in #2399 to have an additional_fields keyword argument for all @jobs in quacc. Will not merge without input from @tomdemeyere.

Requirements

Note: If you are an external contributor, you will see a comment from @buildbot-princeton. This is solely for the maintainers.

Copy link

codecov bot commented Aug 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.45%. Comparing base (d8714bd) to head (4ced60c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2405      +/-   ##
==========================================
- Coverage   98.45%   98.45%   -0.01%     
==========================================
  Files          84       84              
  Lines        3424     3423       -1     
==========================================
- Hits         3371     3370       -1     
  Misses         53       53              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomdemeyere
Copy link
Contributor

Thanks @Andrew-S-Rosen this will be very useful for us, and I think overall that is a positive change for QuAcc, how do you feel about it?

Looking at the code I have nothing more to say!

@Andrew-S-Rosen
Copy link
Member Author

Andrew-S-Rosen commented Aug 10, 2024

Thanks for your comment. I am fine with the change. There is potentially some way in the future to take advantage of the @job decorator such that it will automatically permit the use of additional fields in every Job without having to explicitly define it in every single recipe. But that's for another day and is purely cosmetic.

I will merge this shortly.

@Andrew-S-Rosen Andrew-S-Rosen merged commit 119d281 into main Aug 10, 2024
21 checks passed
@Andrew-S-Rosen Andrew-S-Rosen deleted the additional_fields branch August 10, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants