docs: combine Cython, C, and pybind11 parts #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
commented
Jul 18, 2024
| @@ -39,7 +39,7 @@ jobs: | |||
| run: pip install -r requirements.txt | |||
|
|
|||
| - name: Build site | |||
| run: mkdocs build | |||
| run: mkdocs build --strict | |||
There was a problem hiding this comment.
I also added this. Example of why this must be passed for all mkdocs builds: https://cibuildwheel.pypa.io/en/v2.18.0/options/
Yes, the default is to render the error into the page and report the build passing...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this now has some duplicated information, and someone looking for pybind11 or C API information shouldn't have to read paragraphs about Cython directives. I've build this locally to make sure the nested tabs work.