Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add pybind11 and Cython instructions #42

Merged
merged 3 commits into from
Jul 18, 2024
Merged

feat: add pybind11 and Cython instructions #42

merged 3 commits into from
Jul 18, 2024

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Jul 18, 2024 •
edited
Loading

Adding tabs for pybind11 and Cython.

I have not previewed this yet.

rgommers
rgommers approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @henryiii!

I extended the Cython description a little bit to cover all three methods of doing this. I usually prefer the cython -X... method, so that seemed useful to include.

@rgommers rgommers added the documentation Improvements or additions to documentation label Jul 18, 2024
@rgommers rgommers merged commit e00021e into Quansight-Labs:main Jul 18, 2024
1 check passed
@henryiii
Copy link
Contributor Author

henryiii commented Jul 18, 2024 •
edited
Loading

all three methods of doing this

Great, wasn't sure what to cover, so just covered the source file version.

@henryiii henryiii deleted the patch-2 branch July 18, 2024 18:11
@henryiii
Copy link
Contributor Author

Could you add the docs URL to GitHub's URL spot? I'm used to clicking there for webpages associated with repos.

@rgommers
Copy link
Member

Could you add the docs URL to GitHub's URL spot?

Good idea, done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henryiii @rgommers