clarify limited API support a bit #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommers
approved these changes
Nov 4, 2024
docs/porting.md
Outdated
| currently use the limited API to build wheels that do not depend on a specific | ||
| Python version, you will not be able to use it while shipping binaries for the | ||
| free-threaded build. In practice, the limited API is a subset of the full C API, | ||
| so your extension will almost certainly build, you just cannot set |
There was a problem hiding this comment.
I'd drop "almost certainly", it just made me wonder about corner case scenarios that should really not exist.
docs/porting.md
Outdated
| Python version, you will not be able to use it while shipping binaries for the | ||
| free-threaded build. In practice, the limited API is a subset of the full C API, | ||
| so your extension will almost certainly build, you just cannot set | ||
| `Py_LIMITED_API` at build time. This also means that code inside `#ifdef Py_GIL_DISABLED` checks can use C API constructs outside the limited API if you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.