Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] my info 페이지 토큰 변조 대비 #192

Merged
merged 5 commits into from
Aug 31, 2024
Merged

[Fix] my info 페이지 토큰 변조 대비 #192

merged 5 commits into from
Aug 31, 2024

Conversation

armd482
Copy link
Contributor

@armd482 armd482 commented Aug 30, 2024

🚀 작업 내용

  • my-info prefetch로 변경
  • 스켈레톤 처음 로딩 시에만 나오도록 변경

🚨 관련 이슈 (이슈 번호)

✅ 체크리스트

  • Code Review 요청
  • Label 설정
  • PR 제목 규칙에 맞는지 확인

@armd482 armd482 added 🐞 Fix 버그 수정 📬 API 서버 api 통신 labels Aug 30, 2024
@armd482 armd482 self-assigned this Aug 30, 2024
@bokeeeey bokeeeey changed the title 191 fix my info 페이지 토큰 변조 대비 [Fix] my info 페이지 토큰 변조 대비 Aug 30, 2024
bokeeeey
bokeeeey approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@bokeeeey bokeeeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Young2un
Young2un approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@Young2un Young2un left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니당

src/app/my-info/(account)/wishlist/_components/WishList.tsx Outdated
Comment on lines 24 to 26
const getProductLikesParams: GetProductLikesParams = {
page: searchParams.page || '0',
size: searchParams.size || '10',
const getProductLikesParams = {
page: searchParams.page ?? '0',
size: searchParams.size ?? '10',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빈문자열이 들어올일은 가능성이 없나용??

minjeong9919
minjeong9919 approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@minjeong9919 minjeong9919 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니당 👍

@armd482 armd482 merged commit b9f6499 into develop Aug 31, 2024
@armd482 armd482 deleted the 191-fix-my-info-페이지-토큰-변조-대비 branch August 31, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bokeeeey bokeeeey bokeeeey approved these changes

@Young2un Young2un Young2un approved these changes

@minjeong9919 minjeong9919 minjeong9919 approved these changes

@ggjiny ggjiny Awaiting requested review from ggjiny

Assignees

@armd482 armd482

Labels
📬 API 서버 api 통신 🐞 Fix 버그 수정
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fix] My-info 페이지 토큰 변조 대비
4 participants
@armd482 @minjeong9919 @Young2un @bokeeeey