-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename internal add_control
to _add_control
#13177
base: main
Are you sure you want to change the base?
Conversation
One or more of the following people are relevant to this code:
|
I don't think we need to do this. It's not in the public interface, and I think changing its name like this risks suggesting that naming is what defines the public interface. If we were going to do it, it'd probably be the module we renamed - the function itself is public within ourselves as a package (evidenced by how it's used in more than one file), and it's the module that's private to users. |
Pull Request Test Coverage Report for Build 11092537542Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
I inlined/moved the code from |
Summary
The internal function
add_control
seems to create confusion among users. Here some examples:I think it can be renamed to mitigate that effect.