feat: Doesn't allow owners to exit a locked vehicle

[Mesrine67]

addition of the check if the players are in the vehicle if yes lock on position 4 to lock the vehicle from the inside

[solareon]

This seems counterintuitive to what most players expect with fivem vehicle keys. I gather that lock state 4 requires the vehicle to be unlocked before someone can get out aka like child safety locks on the back seat of most modern vehicles. Additionally we should be using cache.vehicle to check the vehicle of the player.

If we want to add something like this it should be configurable with the default off for those that want the "vanilla" experience.

[Mesrine67]

This seems counterintuitive to what most players expect with fivem vehicle keys. I gather that lock state 4 requires the vehicle to be unlocked before someone can get out aka like child safety locks on the back seat of most modern vehicles. Additionally we should be using cache.vehicle to check the vehicle of the player.

If we want to add something like this it should be configurable with the default off for those that want the "vanilla" experience.

suggest how you see the code?

local function isChildLockEnabled()
    return GetConvar('qbx:vehicleKeys:enableChildLock', 'false') == 'true'
end

--- Manages the opening of locks
--- @param vehicle number? The entity number of the vehicle.
--- @param state boolean? State of the vehicle lock.
--- @param anim any Animation
local function setVehicleDoorLock(vehicle, state, anim)
    if not vehicle then return end
    if not isBlacklistedVehicle(vehicle) then
        if hasKeys(qbx.getVehiclePlate(vehicle)) or areKeysJobShared(vehicle) then

            if anim then
                lib.requestAnimDict('anim@mp_player_intmenu@key_fob@')
                TaskPlayAnim(cache.ped, 'anim@mp_player_intmenu@key_fob@', 'fob_click', 3.0, 3.0, -1, 49, 0, false, false, false)
            end

            TriggerServerEvent('InteractSound_SV:PlayWithinDistance', 5, 'lock', 0.3)
            NetworkRequestControlOfEntity(vehicle)

            local lockstate
            if state ~= nil then
                lockstate = state and 2 or 1
            else
                local currentLockState = GetVehicleDoorLockStatus(vehicle)
                local isPedInVehicle = cache.vehicle == vehicle

                if isChildLockEnabled() and isPedInVehicle and currentLockState == 4 then
                    -- Check if the player is in the vehicle and the lock state is 4, then switch it to 1
                    lockstate = 1
                else
                    lockstate = isPedInVehicle and 4 or (currentLockState % 2) + 1 -- Use state 4 if the player is inside, otherwise 1 or 2
                end
            end

            TriggerServerEvent('qb-vehiclekeys:server:setVehLockState', NetworkGetNetworkIdFromEntity(vehicle), lockstate)
            exports.qbx_core:Notify(locale(lockstate == 2 and 'notify.vehicle_locked' or 'notify.vehicle_unlocked'))

            SetVehicleLights(vehicle, 2)
            Wait(250)
            SetVehicleLights(vehicle, 1)
            Wait(200)
            SetVehicleLights(vehicle, 0)
            Wait(300)
            ClearPedTasks(cache.ped)
        else
            exports.qbx_core:Notify(locale('notify.no_keys'), 'error')
        end
    else
        TriggerServerEvent('qb-vehiclekeys:server:setVehLockState', NetworkGetNetworkIdFromEntity(vehicle), 1)
    end
end

[Manason]

It's easier to review code if you commit the changes to the branch rather than ask us to review a comment. I think you are going in the right direction though. We generally use all lowercase for convars as well as store them in a local variable at the top of the file rather than retrieve via function.

[artur-michalak]

Consider using a function instead of an event.

[Mesrine67]

code tested ✅

[artur-michalak]

Why should it be the default behavior?

[Mesrine67]

should we disable it by default? (I find that for the roleplay action the default setting true is best)

[artur-michalak]

#51 (review)

[artur-michalak]

Will someone be able to get in the car while someone is sitting in?

[Mesrine67]

if it locks on position 4 the car and closes for players who want to exit/enter the vehicle, I send you a video, I wait for a friend and I shoot the video.

[artur-michalak]

What if the locks are open and someone tries to sit as a passenger?

[artur-michalak]

Of course, when the driver is already in the car.

[Mesrine67]

mmmh thank you for making me think that I will adjust the code, I will adjust the code

[Mesrine67]

I'm going to make some changes to qbx_smallresources

[artur-michalak]

Closing as author has not been responsive. Feel free to re-open.