Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shared): clear deprecated tables #614

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

mafewtm
Copy link
Member

@mafewtm mafewtm commented Oct 31, 2024

Description

Clears the deprecated shared tables in order to prevent confusion. Currently a common question is "Why doesn't my armor work?". It's asked not knowing that the two old QB armors are no longer supported but are still in the items table.

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

Copy link
Member

@Manason Manason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to delete these, I think we need to also replace the default ox_inventory data files in the recipe to contain the same items

@mafewtm
Copy link
Member Author

mafewtm commented Oct 31, 2024

If we're going to delete these, I think we need to also replace the default ox_inventory data files in the recipe to contain the same items

The reason to delete these is because the vast majority of these items are unused. I mean if its absolutely necessary we could create a default list of whatever.

@Manason
Copy link
Member

Manason commented Oct 31, 2024

If we're going to delete these, I think we need to also replace the default ox_inventory data files in the recipe to contain the same items

The reason to delete these is because the vast majority of these items are unused. I mean if its absolutely necessary we could create a default list of whatever.

Ok sounds good. Just need to be mindful as we rely on items in other scripts to add them to the recipe

Copy link
Contributor

@solareon solareon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out with the crust!

@solareon solareon merged commit 2c6d7dc into main Oct 31, 2024
4 checks passed
@solareon solareon deleted the clear-deprecated-tables branch October 31, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants