feat: GetVehicleClass server export #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafewtm
approved these changes
Sep 13, 2024
Manason
changed the title
Manason
changed the title
solareon
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new server export GetVehicleClass. This is a way of imitating the native of the same name on the client. It accomplishes this by calling back to a random client to cache all the vehicle models to vehicle class mapping. Knowing a vehicle class on the server side is useful for vehiclekeys, to configure certain properties applied to all vehicles of a certain class. This may be useful in other scripts, which is why I'm adding it to core.
The major drawback of this approach is that the data may not be available as no client may have connected yet. However, the implementation could later be changed to cache this data in the database to avoid a case where no data is available. Using the database is preferable over using vehicles.lua so that users need not manually maintain a cache.