Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: motd #555

Merged
merged 2 commits into from
Oct 6, 2024
Merged

feat: motd #555

merged 2 commits into from
Oct 6, 2024

Conversation

D4isDAVID
Copy link
Member

@D4isDAVID D4isDAVID commented Aug 29, 2024 •
edited
Loading

Description

To improve the onboarding of newbies to Qbox, this PR adds:

  • Client MOTD sent in the chat after the player loads in; can be configured.
  • Server MOTD printed to the console after the server starts; can be disabled.
  • Service messages taken from the txAdminRecipe, repo printed to the console after the server starts; can be disabled.

Server MOTD example:
image

See client MOTD and service message examples here: Qbox-project/txAdminRecipe#86

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

@D4isDAVID D4isDAVID mentioned this pull request Aug 29, 2024
Merged
2 tasks
Manason
Manason requested changes Aug 29, 2024
View reviewed changes
client/events.lua Outdated Show resolved Hide resolved
Manason
Manason previously approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@Manason Manason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a line to the readme for this feature (and any other missing features in there while you are editing!)

solareon
solareon reviewed Aug 29, 2024
View reviewed changes
server/main.lua Outdated Show resolved Hide resolved
solareon
solareon previously approved these changes Aug 29, 2024
View reviewed changes
@D4isDAVID D4isDAVID marked this pull request as draft September 19, 2024 01:06
@D4isDAVID D4isDAVID changed the title feat: welcome message and message of the day feat: motd Sep 19, 2024
@D4isDAVID D4isDAVID marked this pull request as ready for review October 2, 2024 18:35
@D4isDAVID D4isDAVID dismissed stale reviews from solareon and Manason October 2, 2024 18:36

stale

Manason
Manason approved these changes Oct 3, 2024
View reviewed changes
server/motd.lua Show resolved Hide resolved
server/motd.lua Show resolved Hide resolved
@D4isDAVID D4isDAVID merged commit 69dc663 into main Oct 6, 2024
4 checks passed
@D4isDAVID D4isDAVID deleted the feature/welcome-messages branch October 6, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manason Manason Manason approved these changes

@mafewtm mafewtm mafewtm approved these changes

@solareon solareon Awaiting requested review from solareon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@D4isDAVID @solareon @Manason @mafewtm