refactor!: move shared to data #538
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manason
approved these changes
Aug 17, 2024
Manason
approved these changes
Aug 17, 2024
yeah that's a better place. marking draft for now and i'll fix it. |
|
Moved it to config/shared |
|
I think we should just stick with them being in a data folder like this was originally supposed to be tbh. They aren't configs. |
mafewtm
reviewed
Aug 19, 2024
| 'shared/items.lua', | ||
| 'shared/jobs.lua', | ||
| 'shared/locations.lua', | ||
| 'data/*.lua', |
There was a problem hiding this comment.
also this is no longer needed currently
There was a problem hiding this comment.
good catch. i'm not opposed to either solution. just kind of needs to be in it's own place away from actual "code" that needs to execute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apparently the shared folder is just one that folks skip when they update. This moves those files to the data folder where they can be more immutable. This will obviously break stuff from bad people that do things like
require '@qbx_core.shared.items'but those should be few and far between.Checklist