Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update en.lua #123

Merged
merged 3 commits into from
Sep 17, 2023
Merged

Update en.lua #123

merged 3 commits into from
Sep 17, 2023

Conversation

alberttheprince
Copy link
Contributor

Description

Changed Display of Gender to Sex in English locales.

@BerkieBb
Copy link
Contributor

You could've gone a little further and updated the code and name of the translation as well

@alberttheprince
Copy link
Contributor Author

You could've gone a little further and updated the code and name of the translation as well

I wasn't sure if gender was generally used by many different resources, so I only changed it in locales in case other resources rely on code with the term gender in it. Sorry if this isn't good enough, I can look into replacing all of them!

@BerkieBb
Copy link
Contributor

You could've gone a little further and updated the code and name of the translation as well

I wasn't sure if gender was generally used by many different resources, so I only changed it in locales in case other resources rely on code with the term gender in it. Sorry if this isn't good enough, I can look into replacing all of them!

It's only used in client/character.lua once, it's been added only yesterday

@alberttheprince
Copy link
Contributor Author

You could've gone a little further and updated the code and name of the translation as well

I wasn't sure if gender was generally used by many different resources, so I only changed it in locales in case other resources rely on code with the term gender in it. Sorry if this isn't good enough, I can look into replacing all of them!

It's only used in client/character.lua once, it's been added only yesterday

I meant more like outside resources, unless this is handled here differently than multichar handled it

@BerkieBb
Copy link
Contributor

You could've gone a little further and updated the code and name of the translation as well

I wasn't sure if gender was generally used by many different resources, so I only changed it in locales in case other resources rely on code with the term gender in it. Sorry if this isn't good enough, I can look into replacing all of them!

It's only used in client/character.lua once, it's been added only yesterday

I meant more like outside resources, unless this is handled here differently than multichar handled it

I don't get it, it's just a string...

@alberttheprince
Copy link
Contributor Author

alberttheprince commented Sep 12, 2023

OK Mr. BerkieB, I may be too dense to understand, but it seems like other than the locale these other references are referring to charinfo.gender, which (I think?) shouldn't be changed.

Apologies for creating any confusion. I just wanted to change it so end users/players would have a more accurate description of what they were choosing in that category.

I assume I shouldn't change to Sex = or sex =

          ` Gender = character.charinfo.gender == 0 and Lang:t('info.char_male') `

@Manason Manason merged commit 1738f9e into Qbox-project:main Sep 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants