Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modules/utils): spawn vehicle no longer deletes current vehicle #108

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

Manason
Copy link
Member

@Manason Manason commented Aug 8, 2023

Description

  • removed code in SpawnVehicle which deletes the vehicle the player is currently in. This assumption is a side effect of spawning a vehicle and isn't always desired. If deleting a user's current vehicle is preferred, that should be done before calling spawn vehicle
  • cleaned up some duplicate code getting the player's ped

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My code fits the style guidelines.
  • My PR fits the contribution guidelines.

@ChatDisabled ChatDisabled merged commit 4c5e9e5 into main Aug 11, 2023
0 of 3 checks passed
@ChatDisabled ChatDisabled deleted the spawn-vehicle-not-delete-current branch August 11, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants