Various refactoring #562
Merged
Various refactoring #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactor $LET variable handling for easier addition of new presets and exposing internal values to the currently compiling program - exposed DEPENDENCY_SOCKETS for conditional compiling of net helper functions in auto-include afterlastline.bm - added DEBUG_IS_ACTIVE variable indicating program is compiling with $DEBUG features, closes #29
- no longer requires HTTP support to be enabled by $UNSTABLE:HTTP flag, instead libcurl is always pulled together with DEPENDENCY_SOCKETS - adapted helper function WhatisMyIP$ to use libcurl features which are always available now - deleted unneeded $UNSTABLE http tests and revoved the flag from the remaining http tests
- removes some unreliable commented code sections (updating) - guess we won't ever go to reactivate and fix this anyway
- reworked to run through the new auto-include logic, rather than by faking a real $INCLUDE internally - added error messages in case someone is trying to use both color sets in the same program - for the rare case someone really needs both, the $COLOR:0 constants are also added to $COLOR:32, but "z" prefixed
- tests to prove the files are auto-included as expected - testing the exposed $DEBUG state flag - cleaning the dependency system - final adjustments
- adapting all source files to use the new constants provided through auto-include beforefirstline.bi - removed the old constants from global/constants.bi - some formatting
- updating the bootstrap compiler to work under the new conditions
RhoSigma-QB64
requested review from
grymmjack,
mkilgore,
flukiluke,
SteveMcNeill and
a740g
- this is ridiculous, just because line numbers have changed it fails - somebody should rethink that test system - meantime we more fixing the tests, than errors in the source they shall unveil
mkilgore
approved these changes
Nov 3, 2024
| 'These are equal to $COLOR:0 constants, but prefixed with "z" (for zero) | ||
| 'to avoid conflicts with same named constants in the block above. | ||
|
|
||
| CONST zBlack~%% = 0 |
There was a problem hiding this comment.
I don't think it's safe to add more of these since they lack the underscore :-/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the unstable state from the HTTP support. The other big part is refactoring several parts to benefit from the shortly added auto-includes. It also adds a pre-compiler flag indicating the $DEBUG state, this closes #29 .
It's recommended to review commit by commit, the commit notes give more informations.