Fixes and enhancements #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- width/height were off by one compared to the Display dialog - set upper limit for compiler threads to 128 as discussed on Discord
- fixing auto-generated pages for user SUBs and FUNCs taking arrays as arguments - https://discord.com/channels/975381912350752819/1208941399127494667/1274879519387418676
- now allows `_LASTHANDLER` keyword in place of a label to restore back to the last used handler label - will silently fall back to "unhandled" (`ON ERROR GOTO 0`), if no more handlers are in the queue - useful for library makers to restore an old handler, when it was formerly changed for library internal purposes
- checks correct function of `ON ERROR GOTO label` in conjuction with `ON ERROR GOTO _LASTHANDLER`
RhoSigma-QB64
added
bug
RhoSigma-QB64
requested review from
grymmjack,
mkilgore,
flukiluke,
SteveMcNeill and
a740g
a740g
approved these changes
Aug 20, 2024
mkilgore
reviewed
Aug 20, 2024
| @@ -16,6 +16,7 @@ uint32_t error_occurred; | |||
| uint32_t error_retry; | |||
| uint32_t error_err; //=0; | |||
| uint32_t error_goto_line; | |||
| qbs *error_handler_history; | |||
There was a problem hiding this comment.
Rather than a qbs could you use a std::stack<uint32_t>? It seems like that's what you're created and std::stack would avoid all the string manipulation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look into the commit comments.