Refactor Image library #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a740g
requested review from
grymmjack,
mkilgore,
flukiluke,
SteveMcNeill and
RhoSigma-QB64
RhoSigma-QB64
approved these changes
Jul 18, 2024
grymmjack
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the image library by avoiding the inclusion of sub-library implementations within
image.cpp. Now, each component is compiled in its own translation unit, and the resulting object files are added toimage.a. The PR also enables the_SAVEIMAGEcommand to export images in theGIFformat.Update: Adds support for loading
.icoand.curfiles, as well as saving.icofiles, using_LOADIMAGEand_SAVEIMAGErespectively.