Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/filter values #326

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Fix/filter values #326

merged 2 commits into from
Sep 30, 2024

Conversation

EvieePy
Copy link
Member

@EvieePy EvieePy commented Sep 21, 2024

Description

Fixes filter being None where Lavalink doesn't allow Nullable

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
    • I have updated the changelog with a quick recap of my changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
  • I have read and agree to the Developer Certificate of Origin for this contribution

chillymosh
chillymosh approved these changes Sep 29, 2024
View reviewed changes
Copy link
Contributor

@chillymosh chillymosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EvieePy EvieePy merged commit 4adb979 into main Sep 30, 2024
4 checks passed
@EvieePy EvieePy deleted the fix/filter-values branch September 30, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chillymosh chillymosh chillymosh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EvieePy @chillymosh