Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of the inactive player event. #268

Merged
merged 6 commits into from
Jan 7, 2024
Merged

Conversation

EvieePy
Copy link
Member

@EvieePy EvieePy commented Dec 23, 2023

This adds the on_wavelink_inactive_player event which triggers when a Player is considered inactive.

For now I have included a basic example, but in the future will add some more advanced recipes to the documentation.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
    • I have updated the changelog with a quick recap of my changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
  • I have read and agree to the Developer Certificate of Origin for this contribution

wavelink/player.py Outdated Show resolved Hide resolved
wavelink/player.py Outdated Show resolved Hide resolved
Copy link
Contributor

@chillymosh chillymosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EvieePy EvieePy merged commit 21ee454 into main Jan 7, 2024
5 checks passed
@EvieePy EvieePy deleted the feature/inactivity-event branch January 7, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants