Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public node endpoints with payloads. #260

Merged
merged 9 commits into from
Dec 7, 2023

Conversation

EvieePy
Copy link
Member

@EvieePy EvieePy commented Dec 7, 2023

This adds public fetch endpoints to Node. Currently they are private, this makes them public.
These endpoints don't alter the Node or Players in anyway, so there should be no risk of internal mishaps.

In the future I can evaluate making the update endpoints public also.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
    • I have updated the changelog with a quick recap of my changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
  • I have read and agree to the Developer Certificate of Origin for this contribution

Copy link
Contributor

@AbstractUmbra AbstractUmbra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me!
I personally cannot comment on the state of the documentation as I cannot build them locally right now to test, so if you're sure they are all good then this is good with me!

@AbstractUmbra AbstractUmbra merged commit 2cf793d into main Dec 7, 2023
5 checks passed
@AbstractUmbra AbstractUmbra deleted the feature/public-endpoints branch December 7, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants