Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include .measure results in Analysis with ngspice-shared #347

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

infinitymdm
Copy link

Related to #346

This PR allows PySpice to parse .measure results out of ngspice run output and attach them to Analysis objects when using the ngspice-shared simulation backend.

The code changes should be fairly straightforward - just fetch the results of a .meas directive from the response to ngspice run control directives, then pass the measurements up to the Analysis object.

@Kreijstal
Copy link

Is this different than #160 ?

@infinitymdm
Copy link
Author

Is this different than #160 ?

For starters, this PR only changes about 50 LOC vs the 1000 or so in #160. I just return the .measure results by passing them up the call stack. I'm not entirely sure what they're doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants