Get solution for gurobi before exiting enviornment context manager #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #330 +/- ##
=======================================
Coverage 86.00% 86.00%
=======================================
Files 17 17
Lines 4209 4209
Branches 989 989
=======================================
Hits 3620 3620
Misses 430 430
Partials 159 159 ☔ View full report in Codecov by Sentry. |
fneum
approved these changes
Jul 23, 2024
|
thanks @dannyopts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not quite sure when this regression happened by this is the same fix as in #192, it seems it got lost in a merge at some point.
As discussed in the issue, I wonder if there should be a test that we dont access the model after it is closed, but maybe there is a better way to do this than an explicit test (i.e. make it impossible by a code change)
Closes #329