Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Visual Bug Fixes for Theme Selection #26

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MarlonPassos-git
Copy link
Contributor

@MarlonPassos-git MarlonPassos-git commented Jul 28, 2024

Problem

There were several visual bugs when no theme was selected:

  • If nothing was selected and the user's system was set to dark theme, a visual bug caused the page to start with a light theme.
  • On initial loading from the server, the theme switch button did not have a pre-reserved space, causing a layout shift.
  • The initial color of the button in the dark theme made the button invisible.

Video before corrections

After Corrections

Video after Corrections

Copy link

vercel bot commented Jul 28, 2024

@MarlonPassos-git is attempting to deploy a commit to the sylartist's projects Team on Vercel.

A member of the Team first needs to authorize it.

@PxlSyl
Copy link
Owner

PxlSyl commented Jul 29, 2024

Hi! The problem is that I need the custom ThemeContext for managing theme with the icons, but also within the kbar menu. Tried before with the hook from next, but it was'nt working and bugs were even worse than now. So if you have another solution, why not, but for now I won't replace my custom implementation, unless your solution works for both kbar (settings) and icons . But thank you for all your improvements and suggestions!

@MarlonPassos-git
Copy link
Contributor Author

ok, i'll take a look tonight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants