Build: PS2 / PPSSPP / AppIcon Fixes to pass all compile workflow checks #2337
Conversation
rf2222222
force-pushed
the
rf2222222-emuthreeRebirth
branch
4 times, most recently
from
5faafec
to
3e4ee21
Compare
rf2222222
force-pushed
the
rf2222222-emuthreeRebirth
branch
2 times, most recently
from
f867431
to
df44342
Compare
|
Builds for this Pull Request are available at |
rf2222222
force-pushed
the
rf2222222-emuthreeRebirth
branch
from
df44342
to
35b8e4f
Compare
|
Builds for this Pull Request are available at |
rf2222222
force-pushed
the
rf2222222-emuthreeRebirth
branch
2 times, most recently
from
7277a99
to
4c2aa5f
Compare
|
Builds for this Pull Request are available at |
rf2222222
force-pushed
the
rf2222222-emuthreeRebirth
branch
5 times, most recently
from
6881812
to
c0742c0
Compare
|
I see this has active pushes still so I converted to a draft PR. Does this PR override the need for #2334 ? |
rf2222222
force-pushed
the
rf2222222-emuthreeRebirth
branch
from
c0742c0
to
934fe49
Compare
This adds code to get PPSSPP to compile on Apple TV (so Provenance Project compiles on build tests using appletvos), and for Play to compile on iOS (updates the hardcoded paths), on top of 2334. So.. this could just be pointed to merge into 2334, or it could be overridden — it’s up to you. =] These are essentially fixes to get all the build checks to pass. AppIcon in Assets using Single Size (the 1024x1024 image) was throwing an error, which is fixed by specifying individual sizes. A script to auto generate various sizes of icons on iOS/watchOS is added, along with different sizes in Contents.json inside AppIcon. With this, everything should now compile on all tests. |
rf2222222
force-pushed
the
rf2222222-emuthreeRebirth
branch
3 times, most recently
from
d01136d
to
c7a0588
Compare
|
Builds for this Pull Request are available at |
rf2222222
changed the title
Signed-off-by: Joseph Mattello <[email protected]>
Signed-off-by: Joseph Mattello <[email protected]>
rf2222222
force-pushed
the
rf2222222-emuthreeRebirth
branch
3 times, most recently
from
b2cf4ae
to
44c0046
Compare
|
Builds for this Pull Request are available at |
rf2222222
force-pushed
the
rf2222222-emuthreeRebirth
branch
14 times, most recently
from
7eea19c
to
88acab9
Compare
|
Builds for this Pull Request are available at |
rf2222222
force-pushed
the
rf2222222-emuthreeRebirth
branch
from
88acab9
to
1bc83fe
Compare
rf2222222
force-pushed
the
rf2222222-emuthreeRebirth
branch
from
1bc83fe
to
2bb92d8
Compare
|
Builds for this Pull Request are available at |
What does this PR do
Fixes PS2 paths to relative path
Fixes PPSSPP to compile on AppleTV (needs Apple TV MoltenVK to work on AppleTV)
Fixes AppIcon sizes to individual sizes (so it compiles on Azure Xcode 14.1)
Where should the reviewer start
How should this be manually tested
Any background context you want to provide
What are the relevant tickets
Screenshots (important for UI changes)
Questions