Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git Branches section edits #476

Merged
merged 10 commits into from
Jun 7, 2024
Merged

Conversation

anacmontoya
Copy link
Contributor

Changes done to git-branches.md:

  • added note about touch command which does not work on windows
  • fixed typo
  • rewrote Complete Workflow section in Git Branches for clarity

Copy link

github-actions bot commented Jun 6, 2024

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 3843b29
✅ Deployment Preview URL: https://ProjectPythia.github.io/pythia-foundations/_preview/476

@anacmontoya anacmontoya marked this pull request as ready for review June 7, 2024 16:36
@anacmontoya anacmontoya requested a review from a team as a code owner June 7, 2024 16:36
@anacmontoya anacmontoya requested review from brian-rose and dcamron and removed request for a team June 7, 2024 16:36
Copy link
Member

@brian-rose brian-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution @anacmontoya, these are nice edits that help clarify the instructions.

I just left a few suggestions for further clarification.

foundations/github/git-branches.md Outdated Show resolved Hide resolved
foundations/github/git-branches.md Show resolved Hide resolved
foundations/github/git-branches.md Outdated Show resolved Hide resolved
foundations/github/git-branches.md Outdated Show resolved Hide resolved
@anacmontoya
Copy link
Contributor Author

Thanks for this contribution @anacmontoya, these are nice edits that help clarify the instructions.

I just left a few suggestions for further clarification.

Thank you so much for the suggestions. It should be ready now

@anacmontoya anacmontoya requested a review from brian-rose June 7, 2024 18:56
Copy link
Member

@brian-rose brian-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anacmontoya, looks great!

@brian-rose brian-rose merged commit 6ef78db into ProjectPythia:main Jun 7, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants