Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix publish-site.yaml #459

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Fix publish-site.yaml #459

merged 2 commits into from
Sep 17, 2024

Conversation

erogluorhan
Copy link
Member

@erogluorhan erogluorhan commented Sep 16, 2024 •
edited
Loading

In an attempt to fix the Issue #457, remove build_from_code_artifact: 'true' from build job of the publish-site.yaml.

EDIT 2024-9-17: Never mind the above description; we revert those changes. Instead, add include-hidden-files into upload-artifact re this release note per @brian-rose 's comment.

@erogluorhan erogluorhan requested a review from a team as a code owner September 16, 2024 21:48
@erogluorhan erogluorhan requested review from brian-rose, dcamron and jukent and removed request for a team September 16, 2024 21:48
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 16, 2024 •
edited
Loading

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 400a1b1
✅ Deployment Preview URL: https://projectpythia.github.io/_preview/459

@erogluorhan
Copy link
Member Author

erogluorhan commented Sep 16, 2024 •
edited
Loading

@brian-rose @dcamron please see this one and let me know what you think about the change this PR makes

@erogluorhan
Copy link
Member Author

The publish-site action run from this branch past!

@jukent jukent mentioned this pull request Sep 17, 2024
Closed
@erogluorhan erogluorhan changed the title Update publish-site.yaml to remove build_from_code_artifact Fix publish-site.yaml Sep 17, 2024
@jukent jukent mentioned this pull request Sep 17, 2024
Closed
@erogluorhan
Copy link
Member Author

Despite the previous convo in this PR, now we are adding include-hidden-files into upload-artifact re this release note per @brian-rose 's comment.

@erogluorhan erogluorhan requested a review from jukent September 17, 2024 20:08
jukent
jukent approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@jukent jukent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting that the passing book build, here does not mean the publish site action will pass -- but I really hope it does!

@jukent jukent merged commit 1cb0512 into main Sep 17, 2024
6 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 17, 2024
@jukent @github-actions
Delete preview for pull request \#459
3513ba2
@erogluorhan erogluorhan linked an issue Sep 17, 2024 that may be closed by this pull request
publish-site Started to Fail recently due to build-book #457
Closed
@erogluorhan erogluorhan deleted the erogluorhan-patch-publish-site branch September 17, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jukent jukent jukent approved these changes

@brian-rose brian-rose Awaiting requested review from brian-rose brian-rose is a code owner automatically assigned from ProjectPythia/infrastructure

@dcamron dcamron Awaiting requested review from dcamron dcamron is a code owner automatically assigned from ProjectPythia/infrastructure

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

publish-site Started to Fail recently due to build-book
2 participants
@erogluorhan @jukent