Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Similar gallery generation for try_updated_theme #417

Merged

Conversation

anissa111
Copy link
Member

This replicates the look of the old gallery pretty closely with cards instead of panels.

The "...more" button pop-ups do NOT work here

@anissa111 anissa111 requested review from erogluorhan and jukent March 29, 2024 02:12
@anissa111 anissa111 requested a review from a team as a code owner March 29, 2024 02:12
Copy link
Contributor

github-actions bot commented Mar 29, 2024

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 964161b
✅ Deployment Preview URL: In Progress

@anissa111 anissa111 removed the request for review from a team March 29, 2024 02:18
Copy link
Member

@erogluorhan erogluorhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for taking the time to look into i this and come up with a solution! Currently it can't find the 'sphinx_design' dependency at the book build step. I suspect it's because we install the theme from its main branch in the environment here (just temporarily as part of tests in this branch)bit the explicitly added dependency didn't help.

I don't think it'd hurt to merge this and figure the dependency issue after that.

@erogluorhan erogluorhan merged commit 96aa252 into ProjectPythia:try_updated_theme Mar 29, 2024
1 of 3 checks passed
@erogluorhan
Copy link
Member

Actually fixed that dependency issue ; there was a syntax error in the environment file. Book build succeeded, now checking out the artifact it generated

erogluorhan added a commit that referenced this pull request Mar 29, 2024
* Use cookbook-actions from feature branch

* Update deploy job's branch from main to try_updated_theme

* Update environment.yml

* Fix logo_link warning

* Fix html_tehem_options

* Fix google analytics config and cookoff post image

* Fix navbar logo and icons

* Update configs to use the updated theme

* Update environment.yml

* Fix linkcheck

* Update conf.py and custom.css to use the new theme

* Start using 100% page width for navbar and center content per discussion

* Update environment.yml

* Update nightly-build.yaml

* Update publish-site.yaml

* Update environment.yml

* Update nightly-build.yaml

* Trying an alternative yaml to MD parsing

* Update environment.yml

* Update environment.yml

* Similar gallery generation for try_updated_theme (#417)

* similar galery

* similar gallery w/ pre-commit

* remove test print statement

* use theme color

* Update environment.yml to have sphinx_design installed with theme source for now

---------

Co-authored-by: Orhan Eroglu <[email protected]>

* Update environment.yml

* Refactor gallery_generator.py and remove forgotten single quotes

* Indentation fix and dependency removal

* StackOverFlow link

* Update environment.yml

* Update environment.yml

* Update environment.yml

* Update environment.yml

* Update nightly-build.yaml

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: Anissa Zacharias <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants