Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _config.yml to add linkcheck_ignore #20

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Conversation

erogluorhan
Copy link
Member

@erogluorhan erogluorhan commented Dec 2, 2024

Closes #19

Add a linkcheck_ignore to _config.yml for "https://www.ncdc.noaa.gov/cdo-web/search?datasetid=GHCND" since the linkcheck issue seems to be because of this, while there is no actual problem with the NOAA's URL.

Also, change a xarray-docs URL from the optimization-tips anchor to a best-practices one since the former no longer exists in the Xarray docs.

Copy link

github-actions bot commented Dec 2, 2024

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: d7b7f50
✅ Deployment Preview URL: https://ProjectPythia.github.io/dask-cookbook/_preview/20

Copy link
Contributor

@jukent jukent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good fix for now. Should we open an issue to help us remember to check this link again in a month or so?

@erogluorhan
Copy link
Member Author

Seems like a good fix for now. Should we open an issue to help us remember to check this link again in a month or so?

Yes, that's a good idea! You mean the one we added an ignore for, right?

@erogluorhan erogluorhan merged commit 719ed18 into main Dec 4, 2024
2 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 4, 2024
@jukent
Copy link
Contributor

jukent commented Dec 4, 2024

Correct

@erogluorhan
Copy link
Member Author

Opened issue #21 for that; thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly builds failing
2 participants