Skip to content

Commit

Permalink
fix tests by fully reducing expected fill fractions
Browse files Browse the repository at this point in the history
  • Loading branch information
MrToph committed Mar 5, 2024
1 parent ab953c5 commit a564382
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
6 changes: 3 additions & 3 deletions test/foundry/FulfillAdvancedOrder.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,7 @@ contract FulfillAdvancedOrder is BaseOrderTest {
address(0)
);

// Assert six-tenths of the order has been fulfilled.
// Assert three-fifths of the order has been fulfilled.
{
(
bool isValidated,
Expand All @@ -497,9 +497,9 @@ contract FulfillAdvancedOrder is BaseOrderTest {
) = context.consideration.getOrderStatus(orderHash);
assertTrue(isValidated);
assertFalse(isCancelled);
assertEq(totalFilled, 6);
assertEq(totalFilled, 3);

assertEq(totalSize, 10);
assertEq(totalSize, 5);
assertEq(60, test1155_1.balanceOf(address(this), 1));
}
}
Expand Down
12 changes: 6 additions & 6 deletions test/foundry/FulfillAvailableAdvancedOrder.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -996,7 +996,7 @@ contract FulfillAvailableAdvancedOrder is BaseOrderTest {
100
);

// Assert six-tenths of the offer has been fulfilled.
// Assert three-fifths of the offer has been fulfilled.
{
(
bool isValidated,
Expand All @@ -1006,9 +1006,9 @@ contract FulfillAvailableAdvancedOrder is BaseOrderTest {
) = context.consideration.getOrderStatus(orderHash);
assertTrue(isValidated);
assertFalse(isCancelled);
assertEq(totalFilled, 6);
assertEq(totalFilled, 3);

assertEq(totalSize, 10);
assertEq(totalSize, 5);
assertEq(60, test1155_1.balanceOf(address(this), 1));
}
}
Expand Down Expand Up @@ -1093,7 +1093,7 @@ contract FulfillAvailableAdvancedOrder is BaseOrderTest {
100
);

// Assert six-tenths of the offer has been fulfilled.
// Assert three-fifths of the offer has been fulfilled.
{
(
bool isValidated,
Expand All @@ -1103,9 +1103,9 @@ contract FulfillAvailableAdvancedOrder is BaseOrderTest {
) = context.consideration.getOrderStatus(orderHash);
assertTrue(isValidated);
assertFalse(isCancelled);
assertEq(totalFilled, 6);
assertEq(totalFilled, 3);

assertEq(totalSize, 10);
assertEq(totalSize, 5);
assertEq(60, test1155_1.balanceOf(address(this), 1));
}
}
Expand Down

0 comments on commit a564382

Please sign in to comment.