Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MD-Express Version #151

Open
wants to merge 88 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
88 commits
Select commit Hold shift + click to select a range
fea3b96
Updated versions + default username for RabbitMQ
JHancox May 28, 2024
27c28aa
Update docker-compose.yml
JHancox May 28, 2024
89d3bce
Update monai-deploy-express.yml
JHancox May 28, 2024
e0016e0
Create temp.txt
JHancox May 30, 2024
94954c2
Added 2 dicom files CI test
JHancox May 30, 2024
56916f6
Delete deploy/monai-deploy-express/sample-workflows/ci-test-files/tem…
JHancox May 30, 2024
b41e9c8
Update test-monai-deploy-express.yml
JHancox May 30, 2024
2f806c8
Update test-monai-deploy-express.yml
JHancox May 30, 2024
145416a
Update test-monai-deploy-express.yml
JHancox May 30, 2024
65b1b03
Update test-monai-deploy-express.yml
JHancox May 30, 2024
dce832c
Update test-monai-deploy-express.yml
JHancox May 30, 2024
2c2f4e3
Update test-monai-deploy-express.yml
JHancox May 30, 2024
87cf50f
Update test-monai-deploy-express.yml
JHancox May 30, 2024
e0d73df
Update test-monai-deploy-express.yml
JHancox May 30, 2024
5759658
Update test-monai-deploy-express.yml
JHancox May 30, 2024
8ba3832
Update test-monai-deploy-express.yml
JHancox May 30, 2024
1cd896e
Update test-monai-deploy-express.yml
JHancox May 30, 2024
177cc42
Update test-monai-deploy-express.yml
JHancox May 31, 2024
cf8c12b
Update test-monai-deploy-express.yml
JHancox May 31, 2024
e402ac2
Update test-monai-deploy-express.yml
JHancox May 31, 2024
fb43bcc
Update test-monai-deploy-express.yml
JHancox May 31, 2024
2c461f3
Update test-monai-deploy-express.yml
JHancox May 31, 2024
efbf654
Update test-monai-deploy-express.yml
JHancox May 31, 2024
e2143bf
Update test-monai-deploy-express.yml
JHancox May 31, 2024
429544c
Update test-monai-deploy-express.yml
JHancox May 31, 2024
b354d83
Update test-monai-deploy-express.yml
JHancox May 31, 2024
e3c31a9
Update test-monai-deploy-express.yml
JHancox May 31, 2024
b43cacc
Update test-monai-deploy-express.yml
JHancox May 31, 2024
7fb1314
Update test-monai-deploy-express.yml
JHancox May 31, 2024
2082a6b
Update test-monai-deploy-express.yml
JHancox May 31, 2024
47dc5bd
Update test-monai-deploy-express.yml
JHancox May 31, 2024
3c40f6a
Update test-monai-deploy-express.yml
JHancox May 31, 2024
bbfd10c
Update test-monai-deploy-express.yml
JHancox May 31, 2024
670a38b
Update test-monai-deploy-express.yml
JHancox May 31, 2024
c4638cb
Update test-monai-deploy-express.yml
JHancox May 31, 2024
6b75b7e
Update test-monai-deploy-express.yml
JHancox May 31, 2024
3ddcbf1
Update test-monai-deploy-express.yml
JHancox May 31, 2024
14906dd
Update test-monai-deploy-express.yml
JHancox May 31, 2024
217df37
Update test-monai-deploy-express.yml
JHancox May 31, 2024
0004705
Update test-monai-deploy-express.yml
JHancox May 31, 2024
08d53e8
Update test-monai-deploy-express.yml
JHancox May 31, 2024
99a8e16
Update test-monai-deploy-express.yml
JHancox May 31, 2024
677eee0
Update test-monai-deploy-express.yml
JHancox May 31, 2024
0738f20
Update test-monai-deploy-express.yml
JHancox May 31, 2024
840170e
Update test-monai-deploy-express.yml
JHancox May 31, 2024
4fae820
Update test-monai-deploy-express.yml
JHancox May 31, 2024
1a7e0bb
Update test-monai-deploy-express.yml
JHancox May 31, 2024
0363d42
Update test-monai-deploy-express.yml
JHancox May 31, 2024
d5167b2
Update test-monai-deploy-express.yml
JHancox May 31, 2024
cc533f8
Update test-monai-deploy-express.yml
JHancox May 31, 2024
4c81a7f
Update test-monai-deploy-express.yml
JHancox Jun 2, 2024
c96f793
Update test-monai-deploy-express.yml
JHancox Jun 2, 2024
a0621e2
Update test-monai-deploy-express.yml
JHancox Jun 2, 2024
50ba78b
Update test-monai-deploy-express.yml
JHancox Jun 2, 2024
f2487f2
Update test-monai-deploy-express.yml
JHancox Jun 2, 2024
fb7fad9
Update test-monai-deploy-express.yml
JHancox Jun 2, 2024
7b1d915
Update test-monai-deploy-express.yml
JHancox Jun 2, 2024
cc0ce99
Update test-monai-deploy-express.yml
JHancox Jun 3, 2024
d96bb42
Update test-monai-deploy-express.yml
JHancox Jun 3, 2024
92431a0
Update test-monai-deploy-express.yml
JHancox Jun 3, 2024
6af15dd
Update test-monai-deploy-express.yml
JHancox Jun 3, 2024
fcb89fc
Update test-monai-deploy-express.yml
JHancox Jun 4, 2024
ead44fd
Update test-monai-deploy-express.yml
JHancox Jun 4, 2024
430bb2c
Update test-monai-deploy-express.yml
JHancox Jun 4, 2024
85bf0c2
Update test-monai-deploy-express.yml
JHancox Jun 4, 2024
62a2ae3
Update test-monai-deploy-express.yml
JHancox Jun 4, 2024
d9c3884
Update test-monai-deploy-express.yml
JHancox Jun 4, 2024
19bed01
Update test-monai-deploy-express.yml
JHancox Jun 4, 2024
05935c0
Update test-monai-deploy-express.yml
JHancox Jun 4, 2024
82c60ee
Update test-monai-deploy-express.yml
JHancox Jun 4, 2024
3cf13a4
Update test-monai-deploy-express.yml
JHancox Jun 4, 2024
8aae041
Update test-monai-deploy-express.yml
JHancox Jun 4, 2024
077658d
Update test-monai-deploy-express.yml
JHancox Jun 4, 2024
492c365
Update test-monai-deploy-express.yml
JHancox Jun 4, 2024
c139497
Update test-monai-deploy-express.yml
JHancox Jun 5, 2024
a95f37f
Update test-monai-deploy-express.yml
JHancox Jun 5, 2024
8ced668
Update task-manager.json
JHancox Jun 6, 2024
b708e0b
Update workflow-manager.json
JHancox Jun 7, 2024
aa40ff1
Update task-manager.json
JHancox Jun 7, 2024
eaf2c2a
Update .env
JHancox Jun 7, 2024
33b11a8
Update task-manager.json
JHancox Jun 7, 2024
6d27d61
Update task-manager.json
JHancox Jun 7, 2024
ee41088
Update task-manager.json
JHancox Jun 7, 2024
e0f1361
Update test-monai-deploy-express.yml
JHancox Jun 7, 2024
192cbba
Update test-monai-deploy-express.yml
JHancox Jun 7, 2024
8a94c94
Update task-manager.json
JHancox Jun 7, 2024
aa51a56
Update test-monai-deploy-express.yml
JHancox Jun 7, 2024
9ab3316
Update task-manager.json
JHancox Jun 7, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/monai-deploy-express.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ on:
default: 'monai-deploy-express-v'
required: true
type: string
# To address error 403
permissions:
contents: write

# A workflow run is made up of one or more jobs that can run sequentially or in parallel
jobs:
Expand Down
27 changes: 22 additions & 5 deletions .github/workflows/test-monai-deploy-express.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
# This is a basic workflow to help you get started with Actions

name: Test MONAI Deploy Express
on:
push:
Expand All @@ -9,6 +7,8 @@ on:
workflow_dispatch:
# Controls when the workflow will run

permissions:
contents: write

# A workflow run is made up of one or more jobs that can run sequentially or in parallel
jobs:
Expand All @@ -23,26 +23,43 @@ jobs:
- uses: actions/checkout@v3

- name: Start MONAI Deploy Express
continue-on-error: true
working-directory: ./deploy/monai-deploy-express
run: |
./init.sh
docker compose up --wait

- name: Informatics Gateway Health Check
continue-on-error: true
continue-on-error: false
run: |
curl http://localhost:5000/health

- name: Workflow Manager Health Check
continue-on-error: true
continue-on-error: false
run: |
curl http://localhost:5001/health

- name: Task Manager Health Check
continue-on-error: true
continue-on-error: false
run: |
curl http://localhost:5002/health

- name: Get WorkflowID
continue-on-error: false
run: |
curl -X POST http://localhost:8042/instances --data-binary "@deploy/monai-deploy-express/sample-workflows/ci-test-files/IMG0002.dcm"
WORKFLOW_ID=$(curl --request POST --header 'Content-Type: application/json' --data @deploy/monai-deploy-express/sample-workflows/hello-world.json http://localhost:5001/workflows | jq '.workflow_id' )
SIZE=${#WORKFLOW_ID}
echo "GITHUB_SIZE=$(echo $SIZE)" >> $GITHUB_ENV
if [[ $SIZE < 32 ]]; then
echo "WID=false" >> "$GITHUB_ENV"
echo "No WorkflowID"
exit 1
else
echo "WID=true" >> "$GITHUB_ENV"
echo "WorkflowID Present"
fi

- name: Collect Logs
working-directory: ./deploy/monai-deploy-express
continue-on-error: true
Expand Down
5 changes: 5 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"githubPullRequests.ignoredPullRequestBranches": [
"main"
]
}
6 changes: 3 additions & 3 deletions deploy/monai-deploy-express/.env
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# Container Images
INFORMATICS_GATEWAY_IMAGE=ghcr.io/project-monai/monai-deploy-informatics-gateway:0.4.1
INFORMATICS_GATEWAY_CONFIG_IMAGE=dwdraju/alpine-curl-jq:latest
WORKFLOW_MANAGER_IMAGE=ghcr.io/project-monai/monai-deploy-workflow-manager:2023.5.0-beta.238
TASK_MANAGER_IMAGE=ghcr.io/project-monai/monai-deploy-task-manager:2023.5.0-beta.238
WORKFLOW_MANAGER_IMAGE=ghcr.io/project-monai/monai-deploy-workflow-manager:2023.5.0-beta.332
TASK_MANAGER_IMAGE=ghcr.io/project-monai/monai-deploy-task-manager:2023.5.0-beta.332

MINIO_IMAGE=minio/minio:RELEASE.2023-10-16T04-13-43Z
MONGODB_IMAGE=mongo:5.0.12
Expand Down Expand Up @@ -98,7 +98,7 @@ KIBANA_CFG_IP=172.29.0.104
# Host Data Volume Paths
INFORMATICS_GATEWAY_PAYLOADS=.md/mdig/payloads/
INFORMATICS_GATEWAY_DATABASE=.md/mdig/database/
TASK_MANAGER_DATA=$PWD/.md/mdtm/
TASK_MANAGER_DATA=${PWD}/.md/mdtm/
MONAI_DEPLOY_PLUGINS=plug-ins/ # disabled by default

MINIO_DATA=.md/minio/data/
Expand Down
87 changes: 21 additions & 66 deletions deploy/monai-deploy-express/configs/task-manager.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,29 +21,16 @@
},
},
"messaging": {
"retries": {
"retryDelays": "5"
},
"topics": {
"workflowRequest": "md.workflow.request",
"exportComplete": "md.export.complete",
"exportRequestPrefix": "md.export.request",
"taskCallback": "md.tasks.callback"
},
"dicomAgents": {
"dicomWebAgentName": "monaidicomweb",
"scuAgentName": "monaiscu"
},
"publisherServiceAssemblyName": "Monai.Deploy.Messaging.RabbitMQ.RabbitMQMessagePublisherService, Monai.Deploy.Messaging.RabbitMQ",
"publisherSettings": {
"endpoint": "rabbitmq",
"username": "admin",
"password": "admin",
"virtualHost": "monaideploy",
"exchange": "monaideploy",
"deadLetterExchange": "deadLetterExchange",
"deliveryLimit": "5",
"requeueDelay": "0"
"deadLetterExchange": "deadletterExchange",
"deliveryLimit": 3,
"requeueDelay": 0
},
"subscriberServiceAssemblyName": "Monai.Deploy.Messaging.RabbitMQ.RabbitMQMessageSubscriberService, Monai.Deploy.Messaging.RabbitMQ",
"subscriberSettings": {
Expand All @@ -53,10 +40,25 @@
"virtualHost": "monaideploy",
"exchange": "monaideploy",
"deadLetterExchange": "monaideploy-dead-letter",
"exportRequestQueue": "export_tasks",
"deliveryLimit": 3,
"requeueDelay": 30
}
"requeueDelay": 3,
"exportRequestQueue": "export_tasks",
"prefetchCount": 5
},
"retries": {
"retryDelays": "localhost"
},
"topics": {
"workflowRequest": "md.workflow.request",
"exportComplete": "md.export.complete",
"exportRequestPrefix": "md.export.request",
"taskCallback": "md.tasks.callback",
"exportHl7": "md.export.hl7"
},
"dicomAgents": {
"dicomWebAgentName": "monaidicomweb",
"scuAgentName": "monaiscu"
},
},
"storage": {
"serviceAssemblyName": "Monai.Deploy.Storage.MinIO.MinIoStorageService, Monai.Deploy.Storage.MinIO",
Expand All @@ -71,52 +73,5 @@
"serviceName": "test"
}
}
},
"Logging": {
"LogLevel": {
"Default": "Information",
"System": "Warning",
"Microsoft": "Warning",
"Microsoft.EntityFrameworkCore": "Warning",
"Microsoft.Hosting.Lifetime": "Information",
"Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker": "Error",
"Monai": "Debug"
},
"Console": {
"FormatterOptions": {
"ColorBehavior": "Enabled",
"IncludeScopes": true,
"SingleLine": false,
"TimestampFormat": " HH:mm:ss ",
"UseUtcTimestamp": true
}
}
},
"Serilog": {
"Enrich": [ "FromLogContext", "WithMachineName", "WithThreadId" ],
"Properties": {
"enviroment": "Production",
"serviceName": "MTM"
},
"WriteTo": [
{
"Name": "File",
"Args": {
"path": "logs/MTM-.log",
"rollingInterval": "Day",
"rollOnFileSizeLimit": true,
"fileSizeLimitBytes": "10485760",
"retainedFileCountLimit": 30,
"formatter": "Serilog.Formatting.Json.JsonFormatter, Serilog"
}
},
{
"Name": "Http",
"Args": {
"requestUri": "http://logstash:50000",
"queueLimitBytes": null
}
}
]
}
}
13 changes: 9 additions & 4 deletions deploy/monai-deploy-express/configs/workflow-manager.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,10 @@
"workflowRequest": "md.workflow.request",
"exportComplete": "md.export.complete",
"exportRequestPrefix": "md.export.request",
"callbackRequest": "md.tasks.callback"
"callbackRequest": "md.tasks.callback",
"aideClinicalReviewRequest": "aide.clinical_review.request",
"exportHl7": "md.export.hl7",
"exportHl7Complete": "md.export.hl7complete"
},
"dicomAgents": {
"dicomWebAgentName": "monaidicomweb",
Expand All @@ -42,7 +45,7 @@
"virtualHost": "monaideploy",
"exchange": "monaideploy",
"deadLetterExchange": "deadLetterExchange",
"deliveryLimit": "5",
"deliveryLimit": "3",
"requeueDelay": "0"
},
"subscriberServiceAssemblyName": "Monai.Deploy.Messaging.RabbitMQ.RabbitMQMessageSubscriberService, Monai.Deploy.Messaging.RabbitMQ",
Expand All @@ -55,7 +58,8 @@
"deadLetterExchange": "monaideploy-dead-letter",
"exportRequestQueue": "export_tasks",
"deliveryLimit": 3,
"requeueDelay": 30
"requeueDelay": 3,
"prefetchCount": "5"
}
},
"storage": {
Expand All @@ -72,7 +76,8 @@
}
},
"dicomTagsDisallowed": "PatientName,PatientID,IssuerOfPatientID,TypeOfPatientID,IssuerOfPatientIDQualifiersSequence,SourcePatientGroupIdentificationSequence,GroupOfPatientsIdentificationSequence,SubjectRelativePositionInImage,PatientBirthDate,PatientBirthTime,PatientBirthDateInAlternativeCalendar,PatientDeathDateInAlternativeCalendar,PatientAlternativeCalendar,PatientSex,PatientInsurancePlanCodeSequence,PatientPrimaryLanguageCodeSequence,PatientPrimaryLanguageModifierCodeSequence,QualityControlSubject,QualityControlSubjectTypeCodeSequence,StrainDescription,StrainNomenclature,StrainStockNumber,StrainSourceRegistryCodeSequence,StrainStockSequence,StrainSource,StrainAdditionalInformation,StrainCodeSequence,GeneticModificationsSequence,GeneticModificationsDescription,GeneticModificationsNomenclature,GeneticModificationsCodeSequence,OtherPatientIDsRETIRED,OtherPatientNames,OtherPatientIDsSequence,PatientBirthName,PatientAge,PatientSize,PatientSizeCodeSequence,PatientBodyMassIndex,MeasuredAPDimension,MeasuredLateralDimension,PatientWeight,PatientAddress,InsurancePlanIdentificationRETIRED,PatientMotherBirthName,MilitaryRank,BranchOfService,MedicalRecordLocatorRETIRED,ReferencedPatientPhotoSequence,MedicalAlerts,Allergies,CountryOfResidence,RegionOfResidence,PatientTelephoneNumbers,PatientTelecomInformation,EthnicGroup,Occupation,SmokingStatus,AdditionalPatientHistory,PregnancyStatus,LastMenstrualDate,PatientReligiousPreference,PatientSpeciesDescription,PatientSpeciesCodeSequence,PatientSexNeutered,AnatomicalOrientationType,PatientBreedDescription,PatientBreedCodeSequence,BreedRegistrationSequence,BreedRegistrationNumber,BreedRegistryCodeSequence,ResponsiblePerson,ResponsiblePersonRole,ResponsibleOrganization,PatientComments,ExaminedBodyThickness",
"migExternalAppPlugins": [ "Monai.Deploy.InformaticsGateway.PlugIns.RemoteAppExecution.DicomDeidentifier, Monai.Deploy.InformaticsGateway.PlugIns.RemoteAppExecution, Version=0.0.0.0" ]
"migExternalAppPlugins": [ "Monai.Deploy.InformaticsGateway.PlugIns.RemoteAppExecution.DicomDeidentifier, Monai.Deploy.InformaticsGateway.PlugIns.RemoteAppExecution, Version=0.0.0.0" ],
"dataRetentionDays": 10 // note. -1 = never delete
},
"InformaticsGateway": {
"apiHost": "http://informatics-gateway:5000",
Expand Down
Binary file not shown.
Binary file not shown.