Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mc commands #328

Merged
merged 7 commits into from
Jun 12, 2024
Merged

Update mc commands #328

merged 7 commits into from
Jun 12, 2024

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Jun 11, 2024

Description

minio client (mc) has updated some of its command line arguments, which breaks how we add and set policies.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

@mocsharp mocsharp added the enhancement New feature or request label Jun 11, 2024
@mocsharp mocsharp requested a review from neildsouth June 11, 2024 21:34
@mocsharp mocsharp self-assigned this Jun 11, 2024
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.45114%. Comparing base (2361edd) to head (4605433).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #328         +/-   ##
===================================================
+ Coverage   79.40979%   79.45114%   +0.04134%     
===================================================
  Files             38          38                 
  Lines           1491        1494          +3     
  Branches          78          78                 
===================================================
+ Hits            1184        1187          +3     
  Misses           268         268                 
  Partials          39          39                 
Flag Coverage Δ
unittests 79.45114% <87.50000%> (+0.04134%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/MinIO/AmazonSecurityTokenServiceClientFactory.cs 0.00000% <ø> (ø)
src/Plugins/MinIO/ConfigurationKeys.cs 100.00000% <ø> (ø)
...ns/MinIO/Extensions/AccessPermissionsExtensions.cs 77.77778% <ø> (ø)
src/Plugins/MinIO/HealthCheckBuilder.cs 72.72727% <ø> (ø)
src/Plugins/MinIO/MinIoAdminHealthCheck.cs 62.50000% <ø> (ø)
src/Plugins/MinIO/MinIoClientFactory.cs 42.85714% <ø> (ø)
src/Plugins/MinIO/MinIoHealthCheck.cs 80.00000% <ø> (ø)
src/Plugins/MinIO/MinIoStartup.cs 88.88889% <ø> (ø)
src/Plugins/MinIO/MinIoStorageService.cs 68.63469% <ø> (ø)
src/Plugins/MinIO/ServiceRegistration.cs 100.00000% <ø> (ø)
... and 28 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2361edd...4605433. Read the comment docs.

Signed-off-by: Victor Chang <[email protected]>
@mocsharp mocsharp added this to the 1.0.1 milestone Jun 11, 2024
@mocsharp mocsharp requested a review from JHancox June 11, 2024 23:28
Signed-off-by: Victor Chang <[email protected]>
@mocsharp mocsharp merged commit e11f5a3 into develop Jun 12, 2024
10 of 12 checks passed
@mocsharp mocsharp deleted the vchang/minio-mc branch June 12, 2024 16:36
mocsharp added a commit that referenced this pull request Jun 12, 2024
* Bump actions/cache from 3.2.2 to 3.3.0 (#190)

Bumps [actions/cache](https://github.com/actions/cache) from 3.2.2 to 3.3.0.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3.2.2...v3.3.0)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump gittools/actions from 0.9.15 to 0.10.2 (#189)

Bumps [gittools/actions](https://github.com/gittools/actions) from 0.9.15 to 0.10.2.
- [Release notes](https://github.com/gittools/actions/releases)
- [Commits](GitTools/actions@v0.9.15...v0.10.2)

---
updated-dependencies:
- dependency-name: gittools/actions
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump AWSSDK.SecurityToken from 3.7.101.22 to 3.7.101.24 (#194)

Bumps [AWSSDK.SecurityToken](https://github.com/aws/aws-sdk-net) from 3.7.101.22 to 3.7.101.24.
- [Release notes](https://github.com/aws/aws-sdk-net/releases)
- [Commits](https://github.com/aws/aws-sdk-net/commits)

---
updated-dependencies:
- dependency-name: AWSSDK.SecurityToken
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump AWSSDK.S3 from 3.7.103.24 to 3.7.103.27 (#199)

Bumps [AWSSDK.S3](https://github.com/aws/aws-sdk-net) from 3.7.103.24 to 3.7.103.27.
- [Release notes](https://github.com/aws/aws-sdk-net/releases)
- [Commits](https://github.com/aws/aws-sdk-net/commits)

---
updated-dependencies:
- dependency-name: AWSSDK.S3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Remove reference of .NET packages

Signed-off-by: Victor Chang <[email protected]>

* Update license approvals

Signed-off-by: Victor Chang <[email protected]>

* Remove duplicate section of CodeQL scan

Signed-off-by: Victor Chang <[email protected]>

* fix up ci

Signed-off-by: Neil South <[email protected]>

* Throw any error from MinIO with ListObject APIs (#214)

* Throw any error from MinIO when listing objects
* Capture ListObjectsAsync exceptions in VerifyObjectExistsAsync
* Configure minio client timeout
* Throw VerifyObjectsException on error
* Convert MinIO exception with custom exceptions
* Update API doc


Signed-off-by: Victor Chang <[email protected]>

* Update dependencies (#241)

+semver: patch

* Update dependencies: AWSSDK, GuardClauses, FluentAssertions, Moq, xunit, coverlet
* Update MinIo
* Update .NET6 libs
* Update licenses and dependency decisions

Signed-off-by: Victor Chang <[email protected]>

* Remove unused references (#243)

* Remove unused references
* Cleanup licenses
* Update Moq

Signed-off-by: Victor Chang <[email protected]>

* Upgrade to .NET 8 (#281)

* Upgrade to .NET 8

Signed-off-by: Victor Chang <[email protected]>

* Bump codecov/codecov-action from 3.1.1 to 3.1.4 (#232)

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3.1.1 to 3.1.4.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v3.1.1...v3.1.4)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump apache/skywalking-eyes from 0.4.0 to 0.5.0 (#245)

Bumps [apache/skywalking-eyes](https://github.com/apache/skywalking-eyes) from 0.4.0 to 0.5.0.
- [Release notes](https://github.com/apache/skywalking-eyes/releases)
- [Changelog](https://github.com/apache/skywalking-eyes/blob/main/CHANGES.md)
- [Commits](apache/skywalking-eyes@v0.4.0...v0.5.0)

---
updated-dependencies:
- dependency-name: apache/skywalking-eyes
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/checkout from 3 to 4 (#246)

Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/cache from 3.3.0 to 3.3.2 (#247)

Bumps [actions/cache](https://github.com/actions/cache) from 3.3.0 to 3.3.2.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3.3.0...v3.3.2)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/upload-artifact from 3.1.2 to 4.0.0 (#278)

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.2 to 4.0.0.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3.1.2...v4.0.0)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update mc commands (#328)

* Update mc commands

Signed-off-by: Victor Chang <[email protected]>

* Update dependencies

Signed-off-by: Victor Chang <[email protected]>

* Remove windows build

Signed-off-by: Victor Chang <[email protected]>

* Update minio client for testing

Signed-off-by: Victor Chang <[email protected]>

* Update dependency versions

Signed-off-by: Victor Chang <[email protected]>

* Update 3rd party licenses and copyright

Signed-off-by: Victor Chang <[email protected]>

* Update licenses

Signed-off-by: Victor Chang <[email protected]>

---------

Signed-off-by: Victor Chang <[email protected]>

* Update codecov/[email protected]

Signed-off-by: Victor Chang <[email protected]>

* Fix codecov copyright

Signed-off-by: Victor Chang <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Neil South <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Neil South <[email protected]>
Co-authored-by: Neil South <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

3 participants