Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breast density example application to make it work with SDK v0.6+ #491

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

MMelQin
Copy link
Collaborator

@MMelQin MMelQin commented Jun 4, 2024

The breast density example application was first created with App SDK v0.5. Post SDK v0.6 release, the code had been updated and works when running with Python interpreter. The README file, however, was not updated to correctly use the new MONAI Deploy CLI. There was also an application bug that caused model network loading error when run as an MONAI App Package.

Code and the doc were updated and tested in dev env.

BTW, the Sonar Cloud is complaining about code duplication erroneously, which I have not found a way to acknowledge and mark as such.

@MMelQin MMelQin linked an issue Jun 4, 2024 that may be closed by this pull request
Copy link

sonarcloud bot commented Jun 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
13.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@MMelQin MMelQin merged commit 493c771 into main Jun 5, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Outdated/incomplete examples documentation
2 participants