Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the SDK to use newer and updated dependencies, namely Holoscan SDK #481

Merged
merged 24 commits into from
Apr 11, 2024

Conversation

MMelQin
Copy link
Collaborator

@MMelQin MMelQin commented Apr 3, 2024

As the title says, this PR is to update the App SDK to make use of the Holoscan SDK v1.0.3.
Updates are mostly around documentation and the example apps.

Testing was done on Ubuntu 22.04 LTX with CUDA 12.4, and due to the CUDA 12.4 compatibility, Linux Kernel 6.5 HWE is used. Both Python 3.8 and Python 3.10 env were used in testing.

  • all examples tested successfully
  • all notebooks tested successfully
  • documentation updated and release note for v1.0.0 added
  • building documentation needs to be done in Python 3.8 environment as of now

Note:
Jupyter notebooks cannot run as is. This is because the MAP Packager pull the monai-deploy-app-sdk from Pypi unless command option is used to install the monai-deploy-app-sdk package from (the to be released) local wheel file. The example applications would work perfectly in the dev branch with sdk package set up in edit mode.

@MMelQin MMelQin changed the title WIP: Updating the SDK to use updated dependencies Updating the SDK to use newer and updated dependencies Apr 4, 2024
@MMelQin MMelQin changed the title Updating the SDK to use newer and updated dependencies Updating the SDK to use newer and updated dependencies, namely Holoscan SDK Apr 10, 2024
@MMelQin MMelQin self-assigned this Apr 11, 2024
Copy link
Member

@dbericat dbericat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CONTRIBUTING.md Show resolved Hide resolved
Copy link

sonarcloud bot commented Apr 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants