Fix issue 410 where the latest typeguard version 3.x is incompatible #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
MMelQin
force-pushed
the
mqin/issue410_typeguard_incompatible_ver
branch
from
d080da9
to
4608b22
Compare
Signed-off-by: M Q <[email protected]>
…s wrong Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
…f date Also, need to update the code to quiet the complaints from pytype. A couple errors in the source code need to be investigated but for now ignored Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
…es not! Signed-off-by: M Q <[email protected]>
…and quieted Signed-off-by: M Q <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
This PR's main change is to limit the typeguard version range, and the rest of the changes are related to formatting issues reported by the new versions of the format and type checking tools used in the build process. The changes were tested and reviewed outside of github, so the PR can be merged. |
This was
linked to
issues
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to only change the version of typeguard to ~=2.12.1 (which is equivalent "typeguard>=2.12.1, <3") in the requirements file as well as the Jupyter Notebooks, as it had been discovered that the newer v3 caused application runtime issues when validating the IO_context. Limiting the typeguard version to below 3 avoids the false error, and is used as the solution for the time being while the App SDK is migrated.
However, more files had to be updated, not related to the intended changes but more to resolve the complaints from the newer versions of Flake8, pytype, and mypy,
B905zip()without an explicitstrict=parameter,but this is conflicting with pytype and mytype. So, this B905 is ignored in Flake8 settingsFile "/home/mqin/src/monai-deploy-app-sdk/monai/deploy/core/application.py", line 222, in add_flow: New container type for io_maps does not match type annotation [container-type-mismatch], and this error is ignored in the pytype settings because the App SDK will stop using these class when migrated, and, there was no runtime errorsFile "/home/mqin/src/monai-deploy-app-sdk/monai/deploy/operators/dicom_series_to_volume_operator.py", line 229, in prepare_series: No attribute 'first_pixel_on_slice_normal' on monai.deploy.core.domain.dicom_sop_instance.DICOMSOPInstance [attribute-error]. This error is ignored for now, and a new bug has been created for itWith the change and editable App SDK, verified that the newly built MONAI App Package (docker) indeed has the correctly typeguard version 2.12.1 (not 3.0.1 as reported in the issue)
Also tested the Jupyter notebook and verified the all steps executed successful (e.g. running as script, with
execcommand, withpackageandruncommand).